Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 499886

Summary: Operations defined in the context of properties view do not have access to the UiCallback
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: PropertiesAssignee: Pierre-Charles David <pierre-charles.david>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: critical    
Priority: P3 CC: julien.dupont, steve.monnier
Version: 3.1.0Keywords: triaged
Target Milestone: 4.0.1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/79257
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=35f2896a3191551e08e270069106ad1357d20c34
Whiteboard:
Bug Depends on: 499885    
Bug Blocks:    

Description Pierre-Charles David CLA 2016-08-18 04:15:51 EDT 
+++ This bug was initially created as a clone of Bug #499885 +++

Operations defined in the context of a properties view description (e.g. a behavior associated to a widget) are currently given a NoUICallback instance, which prevents any operation that opens an editor, a dialog or anything else that depends on a user interaction to work correctly.

See the forum message at https://www.eclipse.org/forums/index.php/mv/msg/1080168/1740665/#msg_1740665 for an example of a concrete issue this causes: navigation operations are ineffective because NavigationTask.openRepresentation(EObject) relies on the UiCallback it was given to try and open the representation, but SiriusToolServices.executeOperation(EObject, String) uses a dummy NoUiCallback.
Comment 1 Pierre-Charles David CLA 2016-08-18 04:16:14 EDT 
Cloned to report the fix in Sirius 4.0.1.
Comment 2 Eclipse Genie CLA 2016-08-18 05:49:46 EDT 
New Gerrit change created: https://git.eclipse.org/r/79257
Comment 4 Pierre-Charles David CLA 2016-08-23 04:24:53 EDT 
Fix reported.
Comment 5 Pierre-Charles David CLA 2016-11-04 10:15:33 EDT 
Available in Sirius 4.0.1. See https://wiki.eclipse.org/Sirius/4.0.1.