Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 499363

Summary:	[IDE] Remove "Copy of" when copying a project
Product:	[Eclipse Project] Platform	Reporter:	Andrey Loskutov <loskutov>
Component:	IDE	Assignee:	Andrey Loskutov <loskutov>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, markus.kell.r, psuzzi
Version:	4.7	Flags:	daniel_megert: pmc_approved+ psuzzi: review+
Target Milestone:	4.6.1
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=200444 https://git.eclipse.org/r/78614 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f9d16aa400693529e34bfa73f06cf0a666d29dd1 https://git.eclipse.org/r/78705 https://git.eclipse.org/r/#/c/78705/ https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=26384f5e34988d15d91a7e1d40fa6f7f7d267f96 https://bugs.eclipse.org/bugs/show_bug.cgi?id=536673
Whiteboard:

Description Andrey Loskutov

2016-08-08 09:31:33 EDT

While we copy files and folders, since 4.6 we don't propose the "Copy of" prefix (see bug 200444).

I propose to be consistent and implement same for projects. The reason behind is same as for bug 200444 - the first thing user does after copy is to remove this prefix.

Comment 1 Andrey Loskutov

2016-08-08 09:34:51 EDT

The fix will be probably in org.eclipse.ui.dialogs.ProjectLocationSelectionDialog.getCopyNameFor(String) and probably should reuse code from org.eclipse.ui.actions.CopyFilesAndFoldersOperation.getAutoNewNameFor(IPath, IWorkspace)

Comment 2 Andrey Loskutov

2016-08-08 10:06:13 EDT

Proposed patch: https://git.eclipse.org/r/78614

Comment 3 Andrey Loskutov

2016-08-08 10:13:13 EDT

Markus, Dani: objections?

Comment 4 Dani Megert

2016-08-08 10:23:01 EDT

(In reply to Andrey Loskutov from comment #3)
> Markus, Dani: objections?

Nope.

Comment 5 Eclipse Genie

2016-08-08 10:29:48 EDT

New Gerrit change created: https://git.eclipse.org/r/78614

Comment 6 Eclipse Genie

2016-08-08 12:57:54 EDT

Gerrit change https://git.eclipse.org/r/78614 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f9d16aa400693529e34bfa73f06cf0a666d29dd1

Comment 7 Eclipse Genie

2016-08-09 12:27:39 EDT

New Gerrit change created: https://git.eclipse.org/r/78705

Comment 8 Andrey Loskutov

2016-08-09 12:28:33 EDT

I would like to backport this change to 4.6.1
PMC request:
http://dev.eclipse.org/mhonarc/lists/eclipse-pmc/msg02664.html

@Patrik, can you please also review the backported patch?

Comment 9 Andrey Loskutov

2016-08-12 12:21:20 EDT

@Patrik, do you have time to review the backported patch? If not, I will ask someone else.

Comment 10 Patrik Suzzi

2016-08-12 19:51:57 EDT

Andrey, I reviewed the code and tested it in 4_6_maintenance. It works fine. Thanks for providing this patch.

Comment 11 Eclipse Genie

2016-08-13 01:32:22 EDT

Gerrit change https://git.eclipse.org/r/78705 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=26384f5e34988d15d91a7e1d40fa6f7f7d267f96

Comment 12 Andrey Loskutov

2016-08-13 01:33:24 EDT

(In reply to Patrik Suzzi from comment #10)
> Andrey, I reviewed the code and tested it in 4_6_maintenance. It works fine.
> Thanks for providing this patch.

Thanks for reviewing. Merged.

Comment 13 Andrey Loskutov

2016-08-18 07:13:14 EDT

Verified with M20160817-0420