Bugzilla – Full Text Bug Listing
| Summary: | We should be using 'stars' on the preference page(s) for indicating the prefs that will appear under the 'wrench' | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Eric Moffatt <emoffatt> | ||||||
| Component: | Client | Assignee: | Jenny Han <jhan> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | Silenio_Quarti | ||||||
| Version: | 12.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| See Also: |
https://git.eclipse.org/r/78722 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=310e9e9569ff233de6b6d6ca84e8dac7acc2fe39 |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
New Gerrit change created: https://git.eclipse.org/r/78722 Created attachment 263561 [details]
Screencap showing alignment issues
I'm not really sure why it's so much worse on FF (welcome to the web I guess...;-). I had some success setting the vertical alignment of the star and label elements to 'vartical-align: middle' but I'm not sure that it's the right fix...
Thanks Jenn, this looks great on both FF and Chrome... Silenio, I'll let you commit this in case you have any more suggestions... Gerrit change https://git.eclipse.org/r/78722 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=310e9e9569ff233de6b6d6ca84e8dac7acc2fe39 |
Created attachment 263482 [details] mockup of using stars Using a star is a generally understood indicator for 'favorite' which is what I'm really doing when I want to promote a particular pref to the wrench dropdown.