Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 498508

Summary:	Edition of note text should not require one more click than other diagram element
Product:	[Modeling] Sirius	Reporter:	Steve Monnier <steve.monnier>
Component:	Diagram	Assignee:	Steve Monnier <steve.monnier>
Status:	CLOSED FIXED	QA Contact:	Julien Dupont <julien.dupont>
Severity:	normal
Priority:	P3	CC:	julien.dupont, laurent.redor
Version:	3.1.0	Keywords:	triaged
Target Milestone:	4.1.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/77918 https://git.eclipse.org/r/78432 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2793b25ff765a9ea089b57c4634f7662ad2c2dee https://git.eclipse.org/r/78939 https://git.eclipse.org/r/78938 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=655aa41eb75a1082c8a9424a01fc932718559de5 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=adcb5e2ff8100c1f1acfcf1d7aeb25a2222e31d5
Whiteboard:

Description Steve Monnier

2016-07-26 12:14:13 EDT

Three click on a diagram note are needed to trigger the direct edit mode display. However, on other diagram elements only two clicks are needed. We should have the same user interaction for diagram notes.

Comment 1 Eclipse Genie

2016-07-26 12:18:47 EDT

New Gerrit change created: https://git.eclipse.org/r/77918

Comment 2 Eclipse Genie

2016-08-04 04:44:54 EDT

New Gerrit change created: https://git.eclipse.org/r/78432

Comment 3 Eclipse Genie

2016-08-05 11:29:24 EDT

Gerrit change https://git.eclipse.org/r/77918 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2793b25ff765a9ea089b57c4634f7662ad2c2dee

Comment 4 Steve Monnier

2016-08-05 11:31:09 EDT

Validation step:
1- create a note and a text (default palette tools) on any diagram
2- do 2 slow clicks on the note and edit its label
3- do 2 slow clicks on the text and edit its label

Comment 5 Laurent Redor

2016-08-12 07:03:21 EDT

There is regression with the proposed solution: When you select the Note (or Text), the font format actions (label color, bold/italic, font size, ...) are no longer available in tabbar nor in contextual menu.

Comment 6 Eclipse Genie

2016-08-12 07:25:04 EDT

New Gerrit change created: https://git.eclipse.org/r/78939

Comment 7 Eclipse Genie

2016-08-12 07:25:05 EDT

New Gerrit change created: https://git.eclipse.org/r/78938

Comment 8 Eclipse Genie

2016-08-12 11:28:55 EDT

Gerrit change https://git.eclipse.org/r/78938 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=655aa41eb75a1082c8a9424a01fc932718559de5

Comment 9 Eclipse Genie

2016-08-12 11:30:39 EDT

Gerrit change https://git.eclipse.org/r/78939 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=adcb5e2ff8100c1f1acfcf1d7aeb25a2222e31d5

Comment 10 Laurent Redor

2016-08-12 11:31:18 EDT

Pb of comment 5 fixed (another approach has finally be done)

Comment 11 Pierre-Charles David

2016-10-18 11:06:31 EDT

Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.