Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 498497

Summary: Use different color and layer for "Info" markers in overview ruler
Product: [Eclipse Project] Platform Reporter: Andrey Loskutov <loskutov>
Component: TextAssignee: Andrey Loskutov <loskutov>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, markus.kell.r
Version: 4.7   
Target Milestone: 4.7 M1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/77913
https://git.eclipse.org/r/77912
https://bugs.eclipse.org/bugs/show_bug.cgi?id=67620
https://bugs.eclipse.org/bugs/show_bug.cgi?id=498493
https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=eb58ce3a2c247f5bd28a7aabdea58c69a96f94e7
https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=6669ea6b05775e50471c478292b1b6965c981c80
Whiteboard:
Attachments:
Description Flags
screenshot of TextEditor showing lot of info annotations, hiding tasks
none
Screenshot with info color 130,160,190 none

Description Andrey Loskutov CLA 2016-07-26 10:03:17 EDT 
Follow up on bug 498493 and bug 67620. 

Since 4.6 the Java compiler creates "INFO" problems and they are now polluting the overview ruler, as seen in /org.eclipse.jface.text/src/org/eclipse/jface/text/TextViewer.java.

The problem is that one can't see anymore really interesting landmarks, such as "TODO", "FIXME" etc - they use exact same color! Try to find the "FIXME" marker in TextViewer.java :-)

The proposal is to disable showing those "INFO" annotations in the global ruler by default.

I will push a patch shortly.
Comment 1 Eclipse Genie CLA 2016-07-26 10:07:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/77913
Comment 2 Eclipse Genie CLA 2016-07-26 10:07:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/77912
Comment 3 Andrey Loskutov CLA 2016-07-26 10:11:28 EDT 
Created attachment 263315 [details]
screenshot of TextEditor showing lot of info annotations, hiding tasks
Comment 4 Andrey Loskutov CLA 2016-07-26 10:14:44 EDT 
Dani, Markus, AFAIK you were involved in the "INFO" severity changes in 4.6. Can you please comment on this request?
Comment 5 Markus Keller CLA 2016-07-26 12:49:46 EDT 
Created attachment 263320 [details]
Screenshot with info color 130,160,190

The "Infos" annotation color is clearly too intense for the least severe problem type, and it also shouldn't conflict with the color for "Tasks".

I'd change
            annotationType="org.eclipse.ui.workbench.texteditor.info"
to something like
            colorPreferenceValue="130,160,190"

I don't think Infos should be removed from the overview ruler. It would be strange to see only some problem markers there by default. But I agree that Tasks should win over Infos, so I'd reduce the presentationLayer for Infos to 2 or 1.

Bookmarks are currently at 1 and Tasks at 2. The screenshot shows that Tasks at 2 wins over Infos at 2. Tasks shouldn't go higher than 2, since Breakpoints are at 3.
Comment 6 Andrey Loskutov CLA 2016-07-26 13:00:45 EDT 
(In reply to Markus Keller from comment #5)
> Created attachment 263320 [details]
> Screenshot with info color 130,160,190
> 
> The "Infos" annotation color is clearly too intense for the least severe
> problem type, and it also shouldn't conflict with the color for "Tasks".
> 
> I'd change
>             annotationType="org.eclipse.ui.workbench.texteditor.info"
> to something like
>             colorPreferenceValue="130,160,190"
> 
> I don't think Infos should be removed from the overview ruler. It would be
> strange to see only some problem markers there by default. But I agree that
> Tasks should win over Infos, so I'd reduce the presentationLayer for Infos
> to 2 or 1.
> 
> Bookmarks are currently at 1 and Tasks at 2. The screenshot shows that Tasks
> at 2 wins over Infos at 2. Tasks shouldn't go higher than 2, since
> Breakpoints are at 3.

Agree, I'e updated the patch accordingly.
Comment 9 Dani Megert CLA 2016-08-03 06:33:45 EDT 
Verified in I20160802-2000.