Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 498251

Summary:	AbstractFXView and AbstractFXEditor do not dispose their PropertySheetPages.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0.0
Target Milestone:	4.1.0 (Neon.1) M1
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Alexander Nyßen

2016-07-21 04:13:21 EDT

AbstractFXView and AbstractFXEditor do not dispose the PropertySheetPage that might have been created via getAdapter(). This is a potential memory leak. It needs to be properly disposed from within dispose().

Comment 1 Alexander Nyßen

2016-07-21 04:18:06 EDT

I pushed the following changes to origin/master and origin/R4_0_maintenance:

- Fixed that AbstractFXView and AbstractFXEditor did not dispose the PropertySheetPages that might have been created through getAdapter().
- Ensured all local fields are cleared after having been disposed.

Resolving as fixed in 4.1.0 M1.

Comment 2 Alexander Nyßen

2016-07-21 06:54:03 EDT

Reopening this, as the property sheet page is already disposed when the part is closed via the PropertySheet (view) itself. It seems the memory leak is rather caused by an inappropriate dispose() implementation within the PropertySheetPage. I need to further investigate this.

Comment 3 Alexander Nyßen

2016-07-21 08:34:22 EDT

The underlying problem is that PropertySheetPage is not properly disposed (see bug #498275). I removed the disposal calls from AbstractFXView and AbstractFXEditor and resolve this as INVALID.