Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 498191

Summary:	AbstractDomain needs to unregister operation history listener when being disposed.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0.0
Target Milestone:	4.1.0 (Neon.1) M1
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-07-20 06:57:53 EDT

Up to now, AbstractDomain does not unregister the operation history listener when being disposed. This is a potential memory leak. 

In contrast to deregistering it within dispose, we should think of adding registration and deregistration to activate and deactivate (and leave it within setOperationHistory() as well.

Comment 1 Alexander Nyßen

2016-07-21 04:46:07 EDT

I pushed the following changes to origin/master and origin/R4_0_maintenance:

- Ensured operation history listener (for transaction changes) is
properly unregistered when domain is diposed.
- Transferred uncaught exception handler into a constant, so it can be
shared by several domains (and does not have to be unregistered when
disposing one of them).

Resolving as fixed in 4.1.0 M1.