Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 498127

Summary:	Remove unused bookmark view limit constants
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Paul Punke <paulpunke>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	Lars.Vogel, loskutov, paulpunke
Version:	4.7
Target Milestone:	4.7 M2
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/77712 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d7018dc36e3aef7a9b502eaf77753163b13c16b3
Whiteboard:
Bug Depends on:	498056
Bug Blocks:	498125

Description Lars Vogel

2016-07-19 06:56:12 EDT

+++ This bug was initially created as a clone of Bug #498056 +++

In Bug 498056 we increased the limit from 100 to 1000. We should do the same for the Bookmark view to be consistent.

Comment 1 Paul Punke

2016-07-21 13:53:16 EDT

Already fixed with Bug 498056.

Comment 2 Paul Punke

2016-07-21 13:58:13 EDT

The following settings have no effect and can safely be deleted:

org.eclipse.ui.internal.ide.IDEInternalPreferences.LIMIT_BOOKMARKS
org.eclipse.ui.internal.ide.IDEInternalPreferences.BOOKMARKS_LIMIT

I suggest to modify the subject of this ticket to 
"Remove unused bookmark view limit constants"

Comment 3 Paul Punke

2016-07-21 13:58:48 EDT

The following settings have no effect and can safely be deleted:

org.eclipse.ui.internal.ide.IDEInternalPreferences.LIMIT_BOOKMARKS
org.eclipse.ui.internal.ide.IDEInternalPreferences.BOOKMARKS_LIMIT

I suggest to modify the subject of this ticket to 
"Remove unused bookmark view limit constants"

Comment 4 Eclipse Genie

2016-07-21 14:36:06 EDT

New Gerrit change created: https://git.eclipse.org/r/77712

Comment 5 Lars Vogel

2016-07-21 14:41:22 EDT

Thanks Paul. Change looks good to me but as I soon leave for vacation and that this _might_ cause issues downstream, I plan to look at that after my vacation. 

If another committer wants to have a look, please feel free.

Comment 6 Eclipse Genie

2016-08-17 07:06:36 EDT

Gerrit change https://git.eclipse.org/r/77712 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d7018dc36e3aef7a9b502eaf77753163b13c16b3

Comment 7 Lars Vogel

2016-08-17 07:06:52 EDT

Thanks Paul.