Bug 497342

Description Christian Damus 2016-07-05 14:11:45 EDT

This bug was found in regression testing (JUnit test execution) of a prototype for bug 496299:  https://git.eclipse.org/r/#/c/76253/ and it blocks completion of that work.

The LoadResourceSnippet employed installed on the model-set by the Control Mode framework to make diagrams available from model sub-unit resources when they are loaded always fails to make its changes in a transaction when it modifies the editor's sash model.  The reason is that it uses the following statement to attempt to get the contextual editing domain:

    EditingDomain editingDomain = AdapterFactoryEditingDomain.getEditingDomainFor(resource);

but this can never work because a Resource is not a valid input; the result is always null, so the TransactionHelper call never starts a transaction and the editing domain ends up throwing IllegalStateException.