Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 496122

Summary: Remove orion/objects and use the built-in Object.assign
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: ClientAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: ahunter.eclipse, Carolyn_MacLeod, Olivier_Thomann, Silenio_Quarti
Version: 12.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Michael Rennie CLA 2016-06-14 12:23:35 EDT
Now that all of the browser versions we support provide the built-in Object.assign, we should get rid of orion/objects and use that instead.

https://kangax.github.io/compat-table/es6/#test-Object_static_methods_Object.assign
Comment 1 Michael Rennie CLA 2016-06-14 12:51:54 EDT
Double-checking our stated list of supported browsers, and I see IE 11 and safari there, which do not support Object.assign.

Silenio, any chance we could drop support for IE 11 in favour of IE 12 and Safari 8 in favour of Safari 9?

https://projects.eclipse.org/projects/ecd.orion/releases/12.0/plan
Comment 2 Michael Rennie CLA 2016-06-14 13:01:56 EDT
I don't think we could realistically drop support for IE 11, we would cut off windows 7, 8 and 8.1 users who refuse to use a good browser (since 12.0+ are all Edge versions).
Comment 3 Olivier Thomann CLA 2016-06-14 13:08:27 EDT
Yes we can. Nothing prevents them from using a "good" browser. They just need to install Chrome, Safari, Firefox or Opera. We should not make our life miserable because of obsolete browsers.
Comment 4 Carolyn MacLeod CLA 2016-06-14 13:51:10 EDT
Their workplace might require IE 11?
Although if the requirement is just to run some legacy app, then that's no longer a valid excuse on Windows 10 because Edge can launch IE 11 as needed: https://blogs.windows.com/msedgedev/2016/05/19/edge14-ie11-better-together/

Apparently 5.74% of users are on IE 11 (1.55% still on IE 9 - yikes!).
https://www.w3counter.com/globalstats.php

Do we have actual browser data for Orion?
Comment 5 Anthony Hunter CLA 2016-06-14 16:04:25 EDT
We cannot drop IE 11 support, it is a support requirement for us.

With regards to Safari 9, it is the current update for OS/X back to Mavericks so we should be good to make our minimum 9.1.
Comment 6 Michael Rennie CLA 2016-07-19 13:36:48 EDT
(In reply to Anthony Hunter from comment #5)
> We cannot drop IE 11 support, it is a support requirement for us.
> 
> With regards to Safari 9, it is the current update for OS/X back to
> Mavericks so we should be good to make our minimum 9.1.

I'm giving up on this. After wasting hours:

1. I could not find a good place to shim the platform and plugins, that did not cause IE to throw piles of strange exceptions.

2. Not wanting to create a convoluted polyfill, which would completely defeat the purpose of using Object.assign.

On the bright side, on real browsers it quite simplifies the code.

Closing wontfix.