Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 496058

Summary: Improve the default rules to be "good enough" for most metamodels
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: PropertiesAssignee: Melanie Bats <melanie.bats>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: melanie.bats, steve.monnier
Version: unspecifiedKeywords: triaged
Target Milestone: 4.1.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/80496
https://git.eclipse.org/r/80685
https://git.eclipse.org/r/81585
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=81c93156c8d32579562139fe83878eb47db53e58
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6e95e49b0319bf0ed34fbd24c3f2bb44f0d90906
https://git.eclipse.org/r/81888
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e82e19ab7dafa9775a1b11bd0424b8d46cbbfe2c
https://git.eclipse.org/r/82006
https://git.eclipse.org/r/82008
https://git.eclipse.org/r/82045
https://git.eclipse.org/r/82161
https://git.eclipse.org/r/82162
https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=f441572d2a498294b0beff852917f4e3225490de
https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=b692409db20a08a99a4577c2727d00b2a7c631d6
https://git.eclipse.org/r/82329
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=066168088672c0327b69f0e960a7003e144578a2
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=efcc0bf9b38c585822a878eec3a3f7a865f22d09
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bfe4d497c5317f4a411d0543849916c051e40d49
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=73a2c9a96c0df86de5bfd4442a312a345cf7afb9
https://git.eclipse.org/r/82446
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=25d6e26c5b151912ee9bee5f492d0e4da9f9f2d6
https://git.eclipse.org/r/82533
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c3612701f41c1028425dcacf8fdec970cb8f7f80
https://git.eclipse.org/r/83517
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=90732f31868b75bc717a3e7cd408d75369cd2d33
https://git.eclipse.org/r/83537
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=944b392a4d9b43feb113c7c36d9b88f7087e0fd8
Whiteboard:

Description Pierre-Charles David CLA 2016-06-14 04:11:27 EDT
The default rules we apply for properties views when no VSM defines anything more specific are currently relatively basic.

They should be improved to be "good enough" for most metamodels, so that users get nice-looking and fully functional property sheets just by installing the appropriate features.

Achieving this may require changes in the core, not just improving the rules model. For example we probably want to use the "EMF Edit integration services" for all display and edition operations, so we may need a way to register a service class for the context of a Property View Description.
Comment 1 Melanie Bats CLA 2016-07-05 08:28:01 EDT
We should review the default rules for the references in order that when a reference is declared with container=true, we must not show the reference in the property view.
Comment 2 Melanie Bats CLA 2016-09-06 09:31:46 EDT
We should hide the Default tab to keep only the General tab. Use the extension point provided by EEF to hide a legacy tab.
Comment 3 Eclipse Genie CLA 2016-09-06 16:51:06 EDT
New Gerrit change created: https://git.eclipse.org/r/80496
Comment 4 Melanie Bats CLA 2016-09-07 10:45:12 EDT
We should:
* show mandatory feature in bold and optional in normal,
* show deprecated feature in strikethrough,
* disable non changeable and derived features.
Comment 5 Melanie Bats CLA 2016-09-07 10:47:31 EDT
We should represent multiline feature with a text area.
Comment 6 Eclipse Genie CLA 2016-09-08 08:05:33 EDT
New Gerrit change created: https://git.eclipse.org/r/80685
Comment 7 Eclipse Genie CLA 2016-09-21 09:14:31 EDT
New Gerrit change created: https://git.eclipse.org/r/81585
Comment 10 Eclipse Genie CLA 2016-09-26 05:50:54 EDT
New Gerrit change created: https://git.eclipse.org/r/81888
Comment 12 Eclipse Genie CLA 2016-09-27 11:16:38 EDT
New Gerrit change created: https://git.eclipse.org/r/82006
Comment 13 Eclipse Genie CLA 2016-09-27 11:18:24 EDT
New Gerrit change created: https://git.eclipse.org/r/82008
Comment 14 Eclipse Genie CLA 2016-09-28 03:26:00 EDT
New Gerrit change created: https://git.eclipse.org/r/82045
Comment 15 Eclipse Genie CLA 2016-09-28 03:26:00 EDT
New Gerrit change created: https://git.eclipse.org/r/82045
Comment 16 Eclipse Genie CLA 2016-09-29 08:19:43 EDT
New Gerrit change created: https://git.eclipse.org/r/82161
Comment 17 Eclipse Genie CLA 2016-09-29 08:20:56 EDT
New Gerrit change created: https://git.eclipse.org/r/82162
Comment 20 Eclipse Genie CLA 2016-10-02 08:40:26 EDT
New Gerrit change created: https://git.eclipse.org/r/82329
Comment 25 Eclipse Genie CLA 2016-10-04 10:24:42 EDT
New Gerrit change created: https://git.eclipse.org/r/82446
Comment 27 Eclipse Genie CLA 2016-10-05 10:23:45 EDT
New Gerrit change created: https://git.eclipse.org/r/82533
Comment 29 Pierre-Charles David CLA 2016-10-06 08:16:59 EDT
There are certainly other improvements possible given the very vague wording of this ticket, but for 4.1.0 we'll consider it done. Ideas for further improvements and bugfixes should be tracked with other, individual tickets.

For validating this, there are no precise instructions: try the default rules with various kinds of models and see if the result makes sense, is usable and does not cause bugs.
Comment 30 Steve Monnier CLA 2016-10-06 11:01:51 EDT
Validated
Comment 31 Pierre-Charles David CLA 2016-10-18 11:06:41 EDT
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.
Comment 33 Eclipse Genie CLA 2016-10-19 11:06:35 EDT
New Gerrit change created: https://git.eclipse.org/r/83537