Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 496027

Summary: [eslint] upgrade ESLint to version 3.0.1
Product: [ECD] Orion Reporter: Olivier Thomann <Olivier_Thomann>
Component: JS ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: curtis.windatt.public, Michael_Rennie
Version: 12.0   
Target Milestone: 13.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 497709, 497712    
Bug Blocks: 496663    

Description Olivier Thomann CLA 2016-06-13 13:23:21 EDT
Latest version of eslint added more checks regarding the environment values like ecmaVersion, sourceType,... We should catch up with this to make sure we are passing in the same values.
Comment 1 Michael Rennie CLA 2016-06-23 14:49:56 EDT
CQ is here:

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11644
Comment 2 Olivier Thomann CLA 2016-07-11 14:46:04 EDT
I would recommend to move to the version 3.0.1 as it contains the pull request we opened against eslint. If we stay with 2.13.1, we will have to patch again our own version of eslint.
Comment 3 Olivier Thomann CLA 2016-07-11 14:50:02 EDT
We will also need to move the doctrine version to 1.2.2 and estraverse version to 4.2.0. Our escope version should be ok. These are the lastest dependencies for 3.1.0.
Comment 4 Olivier Thomann CLA 2016-07-11 15:20:06 EDT
Updating the title to reflect the move to eslint 3.0.1.
Comment 5 Olivier Thomann CLA 2016-07-12 10:24:31 EDT
Right CQ is here:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11674
Comment 6 Olivier Thomann CLA 2016-07-14 12:42:15 EDT
eslint 3.0.1 uses an external library levn which is used to validate options passed in. We need to see if we need this support as this also requires an external library called type-check.
Will discuss that next week with Michael and Curtis.
Comment 7 Olivier Thomann CLA 2016-08-18 17:43:20 EDT
This requires the CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11850 to be approved before being delivered.