Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 496024

Summary: Warn users when a .eslintrc file is defined for the project
Product: [ECD] Orion Reporter: Olivier Thomann <Olivier_Thomann>
Component: JS ToolsAssignee: Olivier Thomann <Olivier_Thomann>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, Michael_Rennie, Silenio_Quarti, steve_northover
Version: 11.0   
Target Milestone: 12.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed patch
none
Proposed patch none

Description Olivier Thomann CLA 2016-06-13 12:29:45 EDT 
When the user defines a .eslintrc file, it takes precedence over the workspace settings. We should warn the user from the preference page for javascript validation settings that there is a .eslintrc file for the selected project.
Comment 1 Olivier Thomann CLA 2016-06-13 12:31:35 EDT 
Steve, I worked on that with Silenio. I can deliver what we came up with. Then you can test the next build to see whether you like it or not.
Comment 2 Olivier Thomann CLA 2016-06-13 12:34:02 EDT 
Created attachment 262415 [details]
Proposed patch
Comment 3 Olivier Thomann CLA 2016-06-13 13:31:19 EDT 
Delivered. Steve, please give it a try and let me know what you think.
Comment 4 Steve Northover CLA 2016-06-13 13:57:41 EDT 
Spoke to Olivier and we sorted out the warning message.
Comment 5 Olivier Thomann CLA 2016-06-13 14:13:18 EDT 
Created attachment 262416 [details]
Proposed patch

Followup patch that fixes the displayed message.
Comment 6 Olivier Thomann CLA 2016-06-13 14:13:33 EDT 
Delivered.