Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 496001

Summary: [CSS] Preview tooltip for font-family containing quotes is not correct
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: JS ToolsAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie, Mike_Wilson, Olivier_Thomann
Version: 12.0   
Target Milestone: 13.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Curtis Windatt CLA 2016-06-13 10:05:43 EDT
h1 {
  font-family: "Courier new", Courier, mono;
}

When you hover over font-family a preview tooltip (containing an iframe) should show what the font looks like.  However, hovering over the above entry simply shows the default font.

If you remove the quotes around courier new, it works.
Comment 1 Curtis Windatt CLA 2016-06-13 10:10:28 EDT
The quotes are being included in the style string which is double quote delimited.  So the style string ends after "font-family:"
Comment 2 Curtis Windatt CLA 2016-06-13 16:08:02 EDT
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=274c2f74f23b257b0798a983bd973b0b65ce8322
Fixed in master

I fixed quite a few warnings in the file at the same time.  Fix is to replace any double quotes with single quotes when creating the style tag for the iframe.  For file path tooltips I replace double quotes with '&quot;'.