Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495992

Summary:	Improve error message for else after return
Product:	[ECD] Orion	Reporter:	Olivier Thomann <Olivier_Thomann>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	cshekhar.suthar, curtis.windatt.public, Michael_Rennie
Version:	11.0
Target Milestone:	12.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Olivier Thomann

2016-06-13 09:00:07 EDT

The message says: "Unexpected 'else' after 'return'". This is actually misleading as the else is fine at that location. It is just unnecessary.
So it would be better to report: "Unnecessary 'else' after 'return'".

Comment 1 Michael Rennie

2016-06-14 11:35:47 EDT

Fix + tests in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ca7758591231852a5dc015535bfd5cedf9ff61a8

The upstream ESlint bug is:

https://github.com/eslint/eslint/issues/6411