Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495956

Summary:	Deactivate tests at lower compliance levels
Product:	[Eclipse Project] JDT	Reporter:	Jay Arthanareeswaran <jarthana>
Component:	Core	Assignee:	JDT-Core-Inbox <jdt-core-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	manoj.palat, markus.kell.r, sasikanth.bharadwaj, stephan.herrmann
Version:	4.5.1
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:	stalebug

Description Jay Arthanareeswaran

2016-06-13 00:07:14 EDT

Now that we have added one more compliance level to the compiler and the test suite, the number of tests has gone over 80K. Naturally the tests take ever so longer and will impact our Gerrit work flow too.

Hence I am mooting the option of deactivating certain compliance levels for tests, let's say 1.3 and 1.4, perhaps more. However, I have proof or statistic to back that people don't compile at this level. I would like this to be discussed and taken up during our 1.9 work.

Comment 1 Stephan Herrmann

2016-06-13 09:48:53 EDT

I don't have statistics either, but from a test-coverage-p.o.v. wouldn't it make sense to keep 1.4, and instead drop 1.5? Differences between 1.5 and 1.6 are far smaller than differences between 1.4 and 1.5.
So, I'm proposing to *keep*:
  1.4 1.6 1.7 1.8 9
Next candidate to drop could be either of 1.4 (if really nobody uses that anymore) or 1.6 (subsumed by 1.7 tests).

So this is my developers p.o.v., it OTOH we make an official statement that support for 1.4- is no longer maintained, that would of course override my reasoning.

Comment 2 Jay Arthanareeswaran

2016-06-14 02:12:35 EDT

(In reply to Stephan Herrmann from comment #1)
> I don't have statistics either, but from a test-coverage-p.o.v. wouldn't it
> make sense to keep 1.4, and instead drop 1.5? Differences between 1.5 and
> 1.6 are far smaller than differences between 1.4 and 1.5.
> So, I'm proposing to *keep*:
>   1.4 1.6 1.7 1.8 9

I agree with this logic.


> So this is my developers p.o.v., it OTOH we make an official statement that
> support for 1.4- is no longer maintained, that would of course override my
> reasoning.

May be we should explore the option of running the tests at left out levels only for I/M builds and not for Gerrit/N-build/Locally?

Comment 3 Stephan Herrmann

2016-06-14 07:23:04 EDT

(In reply to Jay Arthanareeswaran from comment #2)
> May be we should explore the option of running the tests at left out levels
> only for I/M builds and not for Gerrit/N-build/Locally?

Great idea!

Comment 4 Eclipse Genie

2020-02-05 16:36:54 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 5 Stephan Herrmann

2020-02-05 17:24:07 EST

For the records: this has been addressed by maven profiles test-on-javase-13 etc. which define subsets of compliance levels like:
  -Dcompliance=1.4,1.7,1.8,13
See also bug 537312