Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495901

Summary: [move method] move method changes the order of evaluating prefix/argument expressions
Product: [Eclipse Project] JDT Reporter: Jongwook Kim <jongwook.kim>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: jongwook.kim
Version: 4.5.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard: stalebug

Description Jongwook Kim CLA 2016-06-10 13:48:51 EDT
When A.m is moved to class C using the second parameter, the order of evaluating argument expressions is changed after the move. The m invocation in method n below is evaluated before the move:

new A(), new B(), new C(), new D() in order

After the move, the evaluation order becomes:

new C(), new B(), new A(), new D() 

So the program behavior may change when the argument expressions have side effects.


BEFORE
----------------------------------------------------
class A {
	int i = 0;

	void m(B b, C c, D d) {
		i = 0;
	}

	void n() {
		new A().m(new B(), new C(), new D());
	}
}

class C {
}


AFTER
----------------------------------------------------
class A {
	int i = 0;

	void n() {
		new C().m(new B(), new A(), new D());  // reordering
	}
}

class C {
	void m(B b, A a, D d) {
		a.i = 0;
	}
}
Comment 1 Eclipse Genie CLA 2020-02-25 03:53:24 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.