Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495821

Summary:	Change project encoding from ISO-8859-1 to UTF-8 in eclipse.platform.runtime
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Runtime	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, david_williams, Lars.Vogel, markus.kell.r, psuzzi
Version:	4.6
Target Milestone:	4.7 M2
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/75013 https://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=eace8041f02e176091133c329581ff35dc0bd270
Whiteboard:
Bug Depends on:
Bug Blocks:	399451

Description Lars Vogel

2016-06-09 13:05:56 EDT

I think that is what Dani suggested in https://bugs.eclipse.org/bugs/show_bug.cgi?id=470175#c24

Comment 1 Lars Vogel

2016-06-09 13:08:42 EDT

Adding Dani, so that we can confirm or correct my understanding of his statement.

Comment 2 Eclipse Genie

2016-06-09 13:13:03 EDT

New Gerrit change created: https://git.eclipse.org/r/75013

Comment 3 Dani Megert

2016-06-10 04:56:14 EDT

(In reply to Eclipse Genie from comment #2)
> New Gerrit change created: https://git.eclipse.org/r/75013

WARNING: Before you can merge that change you must check all files for special characters (those that won't be the same when changing the encoding). Those files need to be converted, otherwise they will be mangled.

Comment 4 Lars Vogel

2016-06-10 05:13:20 EDT

(In reply to Dani Megert from comment #3)
> (In reply to Eclipse Genie from comment #2)
> > New Gerrit change created: https://git.eclipse.org/r/75013
> 
> WARNING: Before you can merge that change you must check all files for
> special characters (those that won't be the same when changing the
> encoding). Those files need to be converted, otherwise they will be mangled.

Would such files not show in the Git staging view after I changed the encoding?

Comment 5 Dani Megert

2016-06-10 07:59:41 EDT

(In reply to Lars Vogel from comment #4)
> (In reply to Dani Megert from comment #3)
> > (In reply to Eclipse Genie from comment #2)
> > > New Gerrit change created: https://git.eclipse.org/r/75013
> > 
> > WARNING: Before you can merge that change you must check all files for
> > special characters (those that won't be the same when changing the
> > encoding). Those files need to be converted, otherwise they will be mangled.
> 
> Would such files not show in the Git staging view after I changed the
> encoding?

No. The setting defines how an existing file is read and written. It does not convert any files when changing it.

Comment 6 David Williams

2016-06-10 14:46:34 EDT

Markus gives a tip in bug 399451#c2 on how to search for "non ascii" characters. 
In short, regex search for [\x80-\uFFFF]. 

These may or may not map to the same letter in UTF-8 encoding. 

From what I happen to have loaded in my workspace, I did see one non-ascii character (in a committers name) in DependenciesLeakTest.java. A SMALL LETTER U WITH DIAERESIS? 

I do not *think* it will map, and may need correcting after the setting changes. 

As one source of "mapping characters" see 
http://www.utf8-chartable.de/
(which was just the fist in my google search, there might be better sources.) 

And, all this was from a very quick glance ... just writing it here that there is more to do than simply changing the setting.

Comment 7 Markus Keller

2016-06-10 16:05:29 EDT

Bug 399451 comment 4 tells how to properly set up projects.

Comment 8 Eclipse Genie

2016-09-01 15:48:42 EDT

Gerrit change https://git.eclipse.org/r/75013 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=eace8041f02e176091133c329581ff35dc0bd270

Comment 9 Lars Vogel

2016-09-01 15:49:06 EDT

Thanks David and Markus for the advice.