Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495801

Summary: [1.9] [code completion] requires module reference completion
Product: [Eclipse Project] JDT Reporter: Manoj N Palat <manoj.palat>
Component: CoreAssignee: Manoj N Palat <manoj.palat>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: noopur_gupta
Version: 4.6   
Target Milestone: BETA J9   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/74986
https://bugs.eclipse.org/bugs/show_bug.cgi?id=495863
https://git.eclipse.org/r/81418
Whiteboard:
Bug Depends on:    
Bug Blocks: 486988, 495818    

Description Manoj N Palat CLA 2016-06-09 10:48:24 EDT
code completion at requires in module-info. Assumption is modules will be taken from jars and dependent projects.
Comment 1 Eclipse Genie CLA 2016-06-09 10:52:17 EDT
New Gerrit change created: https://git.eclipse.org/r/74986
Comment 2 Manoj N Palat CLA 2016-06-09 12:49:58 EDT
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/74986

Commit done directly via: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?h=BETA_JAVA9&id=667e56a9d9129b25d42167e15e3a2a5164190faa
Comment 4 Noopur Gupta CLA 2016-06-10 09:40:32 EDT
(In reply to Manoj Palat from comment #3)
> javadoc changes committed via
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?h=BETA_JAVA9&id=b2d70fc49d7cd20c5e22c5ff840977725ef16de5

It should also be updated for the API CompletionProposal.getDeclarationSignature().
Comment 5 Manoj N Palat CLA 2016-06-10 10:09:51 EDT
(In reply to Noopur Gupta from comment #4)
> (In reply to Manoj Palat from comment #3)
> > javadoc changes committed via
> > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> > ?h=BETA_JAVA9&id=b2d70fc49d7cd20c5e22c5ff840977725ef16de5
> 
> It should also be updated for the API
> CompletionProposal.getDeclarationSignature().

Thanks Nooopur - updated via http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?h=BETA_JAVA9&id=f423bd8740242fe78b48b52b7ce1f8495ba68b55
Comment 6 Eclipse Genie CLA 2016-09-20 04:38:49 EDT
New Gerrit change created: https://git.eclipse.org/r/81418
Comment 7 Manoj N Palat CLA 2016-11-29 16:58:20 EST
(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/81418

abandoned this commit as this part of the code has been re-worked via other bugs. with the commit in comment 5, this issue is fixed