Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495770

Summary: Broken links in Sirius documentation
Product: [Modeling] Sirius Reporter: Maxime Porhel <maxime.porhel>
Component: DocumentationAssignee: Jessy Mallet <jessy.mallet>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: normal    
Priority: P3 CC: florian.barbin, julien.dupont, laurent.redor, pierre-charles.david
Version: 3.1.0Keywords: triaged
Target Milestone: 4.1.0   
Hardware: PC   
OS: Mac OS X   
See Also: https://git.eclipse.org/r/75249
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a3e0df9b88aefd09b0ea3469630894ba0c66a998
Whiteboard: backport
Bug Depends on:    
Bug Blocks: 499808    
Attachments:
Description Flags
Help links issue
none
Sirius link broken in documentation none

Description Maxime Porhel CLA 2016-06-09 04:30:30 EDT
In Neon RC and neon info center, several links from the Sirius documentation are broken: clicking on them lead to a blank frame.
Those links points to external pages. Links related to other location in the documentation are ok. 

To reproduce: 
. Take a modeling bundle and open the help contents or go to http://help.eclipse.org/neon/topic/org.eclipse.sirius.doc/doc/index.html?cp=24
. Select Sirius in the toc
. Click on the www.eclipse.org/sirius link at the bottom of the main page. 
> Blank frame 

The Google Chrome's console shows the following error: 
> Refused to display 'https://www.eclipse.org/sirius/' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.

Workaround: right click and open in a new tab (chrome)
Comment 1 Maxime Porhel CLA 2016-06-09 04:36:49 EDT
Created attachment 262331 [details]
Help links issue

Screenshot of the issue on Windows in the help windows. 
On Linux and MacOS, the help is opened in the system browser. The error is not displayed but the user sees a blank frame.
Comment 2 Maxime Porhel CLA 2016-06-09 04:41:20 EDT
All the links of the documentation will have to be checked. 

We already put some  target="_blank" in several links for the previous release, but this time we detected several broken links which used to work fine.
Comment 3 Eclipse Genie CLA 2016-06-14 11:42:53 EDT
New Gerrit change created: https://git.eclipse.org/r/75249
Comment 5 Julien Dupont CLA 2016-09-08 05:03:54 EDT
It does not work with this link https://bugs.eclipse.org/bugs/show_bug.cgi?id=495770

When clicking on sirius link at the bottom of the main page
see screenshot associated.
Comment 6 Julien Dupont CLA 2016-09-08 05:04:27 EDT
Created attachment 264022 [details]
Sirius link broken in documentation
Comment 7 Julien Dupont CLA 2016-10-06 03:43:54 EDT
Tested and works correctly
Comment 8 Pierre-Charles David CLA 2016-10-18 11:08:40 EDT
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.