Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495725

Summary: Remove extra comma quick fix breaks file
Product: [ECD] Orion Reporter: Silenio Quarti <Silenio_Quarti>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: 12.0   
Target Milestone: 12.0   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Silenio Quarti CLA 2016-06-08 13:00:58 EDT
Clone https://github.com/reddit/reddit-mobile.git
Open "test/.eslintrc"
Hover problem with comma and click "Remove Extra ','"

the quick fix removes ", //".
Comment 1 Michael Rennie CLA 2016-06-08 13:32:21 EDT
This is due to name collision for jslint lint problems and ours (eslint). Both produce a problem id'd as 'no-comma-dangle', and since the JS tools also listen / are aware of JSON, our fix is showing up (but we do not actually lint the file).

Its a pretty simple fix, we just need to check that the annotation only marks a single char vs. whatever jslint marks (apparently an arbitrary range rtaher than just the offending comma)