Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495702

Summary:	Quickfixes that are using /^'(.*)'/ regexp to search inside the annotation title are potentially broken for languages other than English
Product:	[ECD] Orion	Reporter:	Olivier Thomann <Olivier_Thomann>
Component:	JS Tools	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	P1	CC:	curtis.windatt.public, Michael_Rennie
Version:	12.0
Target Milestone:	12.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Olivier Thomann

2016-06-08 11:14:31 EDT

I found a bug not being able to quickfix the "add the eslint-directive" because the message was in French.
The regex led to the wrong name being extracted from the annotation's title. Therefore the quickfix doesn't work. Same issue with "add to Globals" quickfix.

The name should be stored as the annotation's data instead of trying to be retrieved from the annotation's title.

Comment 1 Olivier Thomann

2016-06-08 11:52:41 EDT

IF you have "'require' is not defined" error, in French, the extracted name is "require n'".

Comment 2 Olivier Thomann

2016-06-08 13:39:08 EDT

Delivered as commit 31c9d30cf61d4db894dc2118e837bab564743efd.
Michael, please review.

Comment 3 Olivier Thomann

2016-06-08 13:39:35 EDT

I checked that this fix works on beta3 using self-hosting on a French setup.