Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495400

Summary:	Prevent unintended nested graph layout bounds changes.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF Zest	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	5.0.0 (Oxygen) M4
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2016-06-03 09:34:00 EDT

Zest performs automatic layout for nested graphs if the layout bounds of the nested graph change. However, the layout bounds of the nested graph currently change when feedback is added to a node. This unintended layout bounds change has to be prevented so that no unnecessary layout pass is performed.

Comment 1 Matthias Wienand

2016-12-13 07:14:50 EST

I was able to find the cause for the unintended layout-bounds changes: When NodePart is refreshed, CSS properties like CSS classes, CSS id, and CSS style are set to their values without checking if they really need to be updated. However, changing the CSS properties leads to a CSS and layout pass that is performed by JavaFX on the next pulse. To prevent the unnecessary changes, I guarded the setters so that the values are only changed if they need to be updated. The code is published on the master branch, therefore, I resolve this ticket as fixed for 5.0.0 M4.