Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495393

Summary: Extract Local Variable erroneously dissallowed
Product: [Eclipse Project] JDT Reporter: Nikolay Metchev <nikolaymetchev>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 4.6   
Target Milestone: ---   
Hardware: PC   
OS: Windows NT   
Whiteboard: stalebug

Description Nikolay Metchev CLA 2016-06-03 08:44:30 EDT
In the code below if you try and extract local variable the method call getX() you get a pop up saying:
"Code from explicit constructor calls cannot be extracted to a variable".
While the code is ultimately in an explicit super constructor call it can still be extracted into its own variable because it actually lives in an anonymous inner class.

------------------------------------
class Sup {
  public Sup(Runnable run) {};
}
public class Main  extends Sup{
  public Main() {
    super(new Runnable() {
      @Override
      public void run() {
        getX(); //extract local variable here
      }

      public String getX() { return "X"; }
    });
  }
}

-----------Expected result-------------
class Sup {
  public Sup(Runnable run) {};
}
public class Main  extends Sup{
  public Main() {
    super(new Runnable() {
      @Override
      public void run() {
        String x = getX(); //extract local variable here
      }

      public String getX() { return "X"; }
    });
  }
}
Comment 1 Eclipse Genie CLA 2020-04-20 17:58:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.