Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495353

Summary: Update Surefire Plugins to 2.19.1
Product: z_Archived Reporter: Martin Schreiber <Martin.SCHREIBER>
Component: TychoAssignee: Martin Schreiber <Martin.SCHREIBER>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, jan.sievers, mat.booth
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/96944
https://bugs.eclipse.org/bugs/show_bug.cgi?id=522475
https://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=523fdecf7c51323a5af81eb7d573f2c27b1c4ad9
Whiteboard:
Bug Depends on:    
Bug Blocks: 522475    

Description Martin Schreiber CLA 2016-06-03 02:26:36 EDT
Currently Surefire Plugins v2.17 are used. In order to support setting the verbose level of TestNG [1], we need to update the Plugins at least to v2.19.

[1] http://maven.apache.org/surefire/maven-surefire-plugin/examples/testng.html
Comment 1 Martin Schreiber CLA 2017-03-15 04:20:35 EDT
CQ created:

CQ #12887
CQ #12893
CQ #12886
CQ #12892
CQ #12891
CQ #12896
CQ #12889
CQ #12895
CQ #12894
CQ #12888
CQ #12890
Comment 2 Eclipse Genie CLA 2017-05-12 07:57:34 EDT
New Gerrit change created: https://git.eclipse.org/r/96944
Comment 3 Jan Sievers CLA 2017-12-18 04:44:03 EST
although the proposal succeeds I'm a little reluctant in pushing this into 1.1.0 which is due soon

@Martin if you think the new features (or bugfixes?) outweigh the risk of regression, feel free to add this into 1.1.0

otherwise we schedule the target milestone for 1.2.0 and could then start working on JUnit5 in 1.2.0
Comment 4 Martin Schreiber CLA 2017-12-18 04:51:30 EST
Just that TestNG verbose level thing is not worth adding that to 1.1.0 and risk some regressions. Upgrading surefire in combination with adding JUnit5 support sounds good to me.
Comment 6 Jan Sievers CLA 2018-02-22 02:54:31 EST
we have an ITs failure

https://ci.eclipse.org/tycho/job/tycho-its/842/console

Tests run: 28, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:00 min
[INFO] Finished at: 2018-02-22T01:13:31-05:00
[INFO] Final Memory: 36M/458M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project tycho-its: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /jobs/genie.tycho/tycho-nightly/workspace/tycho-its && /opt/public/common/java/oracle/jdk1.8.0_162_x64/jre/bin/java -jar /jobs/genie.tycho/tycho-nightly/workspace/tycho-its/target/surefire/surefirebooter8204791714425794086.jar /jobs/genie.tycho/tycho-nightly/workspace/tycho-its/target/surefire/surefire4702523456461680716tmp /jobs/genie.tycho/tycho-nightly/workspace/tycho-its/target/surefire/surefire_08013041235961306390tmp



could this be related to surefire 2.19.1?
Comment 7 Martin Schreiber CLA 2018-02-22 03:13:59 EST
(In reply to Jan Sievers from comment #6)
> we have an ITs failure
> 
> https://ci.eclipse.org/tycho/job/tycho-its/842/console
> 
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 06:00 min
> [INFO] Finished at: 2018-02-22T01:13:31-05:00
> [INFO] Final Memory: 36M/458M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project tycho-its: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The
> forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /jobs/genie.tycho/tycho-nightly/workspace/tycho-its &&
> /opt/public/common/java/oracle/jdk1.8.0_162_x64/jre/bin/java -jar
> /jobs/genie.tycho/tycho-nightly/workspace/tycho-its/target/surefire/
> surefirebooter8204791714425794086.jar
> /jobs/genie.tycho/tycho-nightly/workspace/tycho-its/target/surefire/
> surefire4702523456461680716tmp
> /jobs/genie.tycho/tycho-nightly/workspace/tycho-its/target/surefire/
> surefire_08013041235961306390tmp
> 
> 
> 
> could this be related to surefire 2.19.1?

I hope not, but all indicators say, that it is related to surefire.
I will keep an eye on that and will re-run the ITs a couple of times if the current build succeeds to see if it was a one-time issue or if it re-occurs after a couple of runs.
Comment 8 Jan Sievers CLA 2018-02-22 06:55:03 EST
(In reply to Martin Schreiber from comment #7)

> > could this be related to surefire 2.19.1?
> 
> I hope not, but all indicators say, that it is related to surefire.
> I will keep an eye on that and will re-run the ITs a couple of times if the
> current build succeeds to see if it was a one-time issue or if it re-occurs
> after a couple of runs.


looks like it's not reproducible:

https://ci.eclipse.org/tycho/job/tycho-its/845/