Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495119

Summary: Wrong compartments/regions size and useless scroll bar
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: normal    
Priority: P3 CC: julien.dupont, laurent.fasani
Version: 3.1.0Keywords: triaged
Target Milestone: 4.1.0   
Hardware: PC   
OS: Windows NT   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=495046
https://git.eclipse.org/r/75214
https://git.eclipse.org/r/75329
https://git.eclipse.org/r/75537
https://git.eclipse.org/r/75567
https://git.eclipse.org/r/75608
https://git.eclipse.org/r/75657
https://git.eclipse.org/r/75700
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=00335437bdc5e46c26e80d72a3b314424fcc40cb
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=66e2c14adca80afa5d357de9fe231da4e4c3e05b
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=656a1a52e2e29e08e77d783fa2e690a140311ffb
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=867a7c3dd81b7c3bbea839d27c7be985a7d7d85e
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=78b1b4122e280143143e3f59da0fb9e36e831441
https://git.eclipse.org/r/76857
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8607cec17331b89136aac7940795a8c36b0d61f0
Whiteboard:
Bug Depends on:    
Bug Blocks: 492607, 497403, 499828    

Description Laurent Redor CLA 2016-06-01 04:51:03 EDT
If a size is defined in the VSM for a container with VStack or HStack as children presentation type, this can lead to a useless scroll bar.

Steps to reproduce:
* Imports the project from compartments.zip (https://bugs.eclipse.org/bugs/attachment.cgi?id=262135 from bug 495046)
* Open the diagram VStackDiag
* Use the tool EPackage to create a package container on the diagram with default size (only one click on the diagram)
* Use the tool EClassList to create a class in the package
* KO: A scroll bar appears in the container. 

Another steps to reproduce:
* Use same diagram
* Use the tool EPackageWithOneClass to create a package container with a class inside it with default size (only one click on the diagram)
* KO: A scroll bar appears in the container.

This scroll bar does not disappear even if the container is resized.

The problem does not exist if the size of the VStack container mapping defined of the VSM is {-1, -1} instead of {5, 5}.
Comment 1 Laurent Redor CLA 2016-06-01 05:27:28 EDT
If the size is set to {10, 10}, we have a problem similar to bug 495046:
* The height of the container is not of 100 pixels.
* The width of the class is not fit to the width of the container.
Comment 2 Laurent Redor CLA 2016-06-03 08:50:45 EDT
(In reply to Laurent Redor from comment #0)
> Steps to reproduce:
> * Imports the project from compartments.zip
> (https://bugs.eclipse.org/bugs/attachment.cgi?id=262135 from bug 495046)

The good attachment is https://bugs.eclipse.org/bugs/attachment.cgi?id=262220
Comment 3 Eclipse Genie CLA 2016-06-14 02:26:02 EDT
New Gerrit change created: https://git.eclipse.org/r/75214
Comment 4 Eclipse Genie CLA 2016-06-15 11:30:03 EDT
New Gerrit change created: https://git.eclipse.org/r/75329
Comment 5 Eclipse Genie CLA 2016-06-20 04:01:21 EDT
New Gerrit change created: https://git.eclipse.org/r/75537
Comment 6 Eclipse Genie CLA 2016-06-20 12:00:00 EDT
New Gerrit change created: https://git.eclipse.org/r/75567
Comment 7 Eclipse Genie CLA 2016-06-21 05:39:50 EDT
New Gerrit change created: https://git.eclipse.org/r/75608
Comment 8 Eclipse Genie CLA 2016-06-21 12:50:19 EDT
New Gerrit change created: https://git.eclipse.org/r/75657
Comment 9 Eclipse Genie CLA 2016-06-22 05:55:08 EDT
New Gerrit change created: https://git.eclipse.org/r/75700
Comment 15 Eclipse Genie CLA 2016-07-07 10:27:14 EDT
New Gerrit change created: https://git.eclipse.org/r/76857
Comment 17 Pierre-Charles David CLA 2016-10-18 11:07:00 EDT
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.