Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495112

Summary:

Remove DynamicAnchorELetterSnippet.

Product:

[Tools] GEF

Reporter:

Alexander Nyßen <nyssen>

Component:

GEF FX

Assignee:

Alexander Nyßen <nyssen>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

0.2.0

Target Milestone:

4.0.0 (Neon) RC4

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Screenshot showing the wrong vertex positions	none

Description Alexander Nyßen

2016-06-01 04:22:26 EDT

The DynamicAnchorELetterSnippet is broken. The vertex positions are not rendered at the appropriate locations (probably a local-to-parent transformation is missing). Also, compared to the 0.2.0 the computation seems to be changed and does no longer correspond to the documentation at GEF/GEF4/FX. We should ensure the example is productive again and the implementation and documentation are in-sync.

Comment 1 Alexander Nyßen

2016-06-01 04:23:07 EDT

Created attachment 262149 [details]
Screenshot showing the wrong vertex positions

Comment 2 Alexander Nyßen

2016-06-01 22:23:51 EDT

I pushed the following changes to origin/master:

- Ensure computeAnchorageReferencePointInLocal() does not throw an exception in case of a geometry different to shape or path, but simply returns null to indicate fallback to projection.
- Updated javadoc of ChopBoxStrategy to properly reflect the currently implemented behavior.
- Removed the DynamicAnchorELetterSnippet. As the logic of the ChopBoxStrategy has been very much simplified (it now falls back to the nearest projection in case the center is not contained in the anchorage reference geometry), no explicit example is required to explain its computation. We could think of building up a similar example but where the center is contained.
- Removed it from the FX.Examples documentation as well as from the FX documentation.

Resolving as fixed in 4.0.0 RC4.