Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 495065

Summary:	Quick Access doesn't show Previous Choices when toolbar item not visible
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Patrik Suzzi <psuzzi>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, ivcha, Lars.Vogel, loskutov, mistria, psuzzi
Version:	4.6
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/74701 https://bugs.eclipse.org/bugs/show_bug.cgi?id=500618
Whiteboard:

Description Markus Keller

2016-05-31 15:27:57 EDT

I20160529-2000

Quick Access doesn't show Previous Choices when the "Quick Access" toolbar item is not visible and the popup is shown with an "info" color background at the center of the screen.

I don't see why the visibility of the tool item should disable the Previous Choices feature.

Concrete use case: I tested the new "Toggle visibility the window toolbars" feature and was surprised that I can't just press "Ctrl+3, Enter" to get the toolbars back.

Comment 1 Lars Vogel

2016-05-31 16:05:17 EDT

Patrik, can you handle this one?

Comment 2 Patrik Suzzi

2016-05-31 19:19:21 EDT

I'll take a stab at it

Comment 3 Patrik Suzzi

2016-06-01 14:38:08 EDT

Analysis-1

Looking at QuickAccessHandler#execute(), When pressing Ctrl+3, we have two different popups:

Normal QA Popup: when toolbar is visible, we get the previously stored SearchField, that is responsible to create a Dialog
Legacy QA Popup: when toolbar is not visible we create a new QuickAccessDialog, that has yellow Info background

I verified the two are using the same method for filtering

But the Legacy Yellow QA Popup is never calling the SearchField#handleElementSelected(..) which is responsible to store the last selected element [via addPreviousPick(..) ]. 

Actually, since a new instance of QuickAccessDialog is created at each call, it is not made to store the previous pick.

Comment 4 Eclipse Genie

2016-06-06 14:20:17 EDT

New Gerrit change created: https://git.eclipse.org/r/74701

Comment 5 Patrik Suzzi

2016-06-06 14:33:17 EDT

Now the previous picks are shared between legacy and E4 Quick Access http://i.imgur.com/AJnwxFc.gifv

Comment 6 Patrik Suzzi

2016-09-08 10:47:23 EDT

*** Bug 500944 has been marked as a duplicate of this bug. ***

Comment 7 Patrik Suzzi

2018-06-16 16:02:12 EDT

*** Bug 535947 has been marked as a duplicate of this bug. ***

Comment 8 Dani Megert

2018-07-31 12:23:43 EDT

Patrik, please either fix or remove the target milestone.

Comment 9 Mickael Istria

2019-06-14 17:20:46 EDT

Yes another issue that a factorization of the Quick Access around a single UI with possiblity multiple entry-points of different forms could (have) avoid(ed)

Comment 10 Lars Vogel

2019-08-08 03:13:50 EDT

Lets solve this as part of Bug 500618.

*** This bug has been marked as a duplicate of bug 500618 ***