Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 494939

Summary:	[find/replace] dialog too wide after having searched for a long string
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	Text	Assignee:	Christian Georgi <christian.georgi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	christian.georgi, daniel_megert
Version:	4.6	Flags:	markus.kell.r: review+ daniel_megert: review+
Target Milestone:	4.6 RC4
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/73982 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c901ab208a061d738dbf94ea4588d40c5a58f210
Whiteboard:
Bug Depends on:	487357
Bug Blocks:

Description Markus Keller

2016-05-30 12:26:37 EDT

4.6.0.I20160529-2000, worked fine before bug 487357 (e.g. in 4.5.2)

Open the Find/Replace dialog and search for a longer string like this:

Hello World 1, Hello World 2, Hello World 3, Hello World 4, Hello World 5

Then resize the dialog a bit.

=> A horizontal scroll bar appears and the "Scope" group jumps out of view, although there's plenty of space in the dialog. The Find/Replace combo drop-down arrows also jump out of view, making interaction tedious.

The problem only goes away after the long string got pruned from the find history (search for 8 short patterns and then close/reopen the dialog).

Just removing the SWT.H_SCROLL flag from the ScrolledComposite doesn't help.

Comment 1 Eclipse Genie

2016-05-30 16:11:49 EDT

New Gerrit change created: https://git.eclipse.org/r/73982

Comment 2 Christian Georgi

2016-05-30 16:17:41 EDT

Fixed by only allowing the dialog to scroll vertically.

Comment 3 Markus Keller

2016-05-31 10:19:35 EDT

Reviewed and tested on all 3 platforms.

+1 for RC4. I'd fix this, but I can also live with moving it to 4.6.1.

Comment 4 Christian Georgi

2016-05-31 10:21:16 EDT

(In reply to Markus Keller from comment #3)
> Reviewed and tested on all 3 platforms.
> 
> +1 for RC4. I'd fix this, but I can also live with moving it to 4.6.1.

If we know the current thing is broken and we have a verified fix, why not add it to 4.6.0?

Comment 5 Markus Keller

2016-05-31 10:33:42 EDT

On the Mac, it's even worse than on Windows, since the scrollbars by default disappear after a resize operation.

No issue on GTK3, since the preferred width of a Combo doesn't seem to depend on the contents of the text field or drop-down.


(In reply to Christian Georgi from comment #4)
> If we know the current thing is broken and we have a verified fix, why not
> add it to 4.6.0?

Because Eclipse is a product and not an in-house solution. Every fix has a potential to break more things in circumstance that have not been tested. RC4 is our last chance, so every change is considered risky at this point. More details: https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php

Comment 6 Eclipse Genie

2016-05-31 11:25:57 EDT

Gerrit change https://git.eclipse.org/r/73982 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c901ab208a061d738dbf94ea4588d40c5a58f210

Comment 7 Dani Megert

2016-05-31 11:27:00 EDT

(In reply to Markus Keller from comment #3)
> +1 for RC4. I'd fix this

+1.