Bugzilla – Full Text Bug Listing
| Summary: | Ability to disable Sites plugin | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Alexei Alexandrov <alexei.alexandrov> |
| Component: | Server | Assignee: | Silenio Quarti <Silenio_Quarti> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Silenio_Quarti |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
|
Description
Alexei Alexandrov
This can be done by altering the defaults.prefs file. You need to remove the orion plugin (orionSharedWorker.js) and add which individual plugin you want to keep. Which of the two default.prefs files should be modified? ./bundles/org.eclipse.orion.client.ui/web/defaults.pref ./modules/orionode/lib/orionode.client/defaults.pref For the java server change: ./bundles/org.eclipse.orion.client.ui/web/defaults.pref For the node server change: ./modules/orionode/lib/orionode.client/defaults.pref I have applied this change below locally. Then I do "node ./modules/orionode/server.js" and visit localhost:8081 in the browser hitting CMD-SHIFT-R on my Mac to force reload with caching disabled. But I can still see the Sites button in the vertical bar on the left. Am I missing something?
diff --git a/modules/orionode/lib/orionode.client/defaults.pref b/modules/orionode/lib/orionode.client/defaults.pref
index f098377..1448c9a 100644
--- a/modules/orionode/lib/orionode.client/defaults.pref
+++ b/modules/orionode/lib/orionode.client/defaults.pref
@@ -1,7 +1,5 @@
{
"/plugins":{
- "plugins/orionSharedWorker.js": true,
- "git/plugins/gitPlugin.html":true,
"webtools/plugins/webToolsPlugin.html":true,
"javascript/plugins/javascriptPlugin.html":true,
"edit/content/imageViewerPlugin.html":true,
Try changing the defaults.pref to the following. Clear cache and clear local storage (localStorage.clear() in the console).
------------
{
"/plugins":{
"plugins/fileClientPlugin.html":true,
"plugins/authenticationPlugin.html":true,
"plugins/jslintPlugin.html":true,
"plugins/googleAnalyticsPlugin.html":true,
"plugins/languageToolsPlugin.html":true,
"plugins/preferencesPlugin.html":true,
"plugins/pageLinksPlugin.html":true,
"plugins/taskPlugin.html":true,
"plugins/webEditingPlugin.html":true,
"profile/userservicePlugin.html":true,
"plugins/helpPlugin.html":true,
"shell/plugins/shellPagePlugin.html":true,
"git/plugins/gitPlugin.html":true,
"webtools/plugins/webToolsPlugin.html":true,
"javascript/plugins/javascriptPlugin.html":true,
"edit/content/imageViewerPlugin.html":true,
"edit/content/jsonEditorPlugin.html":true
}
}
--------------------
This seems to work. Is there a way to force a cleanup of the cached information so that if I change the set of plugins in my installation the users don't have to cleanup their browser state manually?
Another question (I can file another request for this if needed): I am also trying to disable the Shell plugin. I tried removing the
"shell/plugins/shellPagePlugin.html":true,
line from the defaults.pref file, but when I do that the UI opens pretty much empty, no directory listing or anything.
Thanks for the help!
Also, how can I disable the toolbar with deployment actions (such as "Deploy the App from the Workspace" and such)? Sorry for using this issue as an uber umbrella for these questions, I can split this out. (In reply to Alexei Alexandrov from comment #6) > This seems to work. Is there a way to force a cleanup of the cached > information so that if I change the set of plugins in my installation the > users don't have to cleanup their browser state manually? > I do not think there is any easy to the automatically clear the local storage in the current implementation, but the local storage plugin cache expires 24 hours. So the end user should eventually see the modification. > Another question (I can file another request for this if needed): I am also > trying to disable the Shell plugin. I tried removing the > > "shell/plugins/shellPagePlugin.html":true, > > line from the defaults.pref file, but when I do that the UI opens pretty > much empty, no directory listing or anything. > > Thanks for the help! This should have worked. Ensure that the plugins have all the services loaded in the settings page (Plugin tab). If there no files in the navigator, it usually means that the file client plugin failed to initialize. Try reloading the plugins by clicking the Reload All button. (In reply to Alexei Alexandrov from comment #7) > Also, how can I disable the toolbar with deployment actions (such as "Deploy > the App from the Workspace" and such)? Sorry for using this issue as an > uber umbrella for these questions, I can split this out. Unfortunately, this can only done by hacking the code. Take a look at http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/tree/bundles/org.eclipse.orion.client.ui/web/edit/setup.js#n634 Looks like disabling the shell plugin worked after cleaning everything up. Thanks! Regarding the run bar - would it be possible to add a preference property that could be set by default to hide it? I can send a PR if you are OK with this. A friendly ping on my last question. (In reply to Alexei Alexandrov from comment #10) > Looks like disabling the shell plugin worked after cleaning everything up. > Thanks! > > Regarding the run bar - would it be possible to add a preference property > that could be set by default to hide it? I can send a PR if you are OK with > this. Please open a separate bug for the RunBar preference. Filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=497255. Here is the proposed change: https://github.com/eclipse/orion.client/pull/58 I also filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=497257 which is one more thing (seemingly last) we want to customize. Silenio, just wondering if you had a chance to look at the patch? Sorry, I am not in the office until the end of next week. I will try to find someone else to review it. A friendly ping on this. Closing this one since there is no outstanding issue. |