Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 494479

Summary:	NodeUtils.getGeometricOutline() should have specific treatment for GeometryNodes with ITranslatable geometry.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF FX	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 (Neon) RC2
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-05-24 15:49:05 EDT

Currently, NodeUtils.getGeometricOutline() returns the transformed Geometry, while the transform is a simple translation. To optimize performance, in case the Geometry implements ITranslatable, it should simply be translated. This way, a Rectangle geometry would for instance be preserved as a Rectangle, whereas after transformation it would be a Polygon.

Comment 1 Alexander Nyßen

2016-05-24 16:05:57 EDT

I pushed the following changes to origin/master:

- Ensured that NodeUtils.getGeometricOutline() has a special treatment for GeometryNodes with an ITranslatable geometry. This improves performance significantly, as Rectangle geometries will be preserved.
- Added a NodeUtilsTests class to confirm the expected behavior.

Resolving as fixed in 4.0.0 RC3.

Comment 2 Alexander Nyßen

2016-05-25 09:43:42 EDT

Reschedule to 4.0.0 RC2, as this was included in an contribution update.