Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 494439

Summary:	Contributions missing from the Paho IP Log
Product:	Community	Reporter:	Wayne Beaton <wayne.beaton>
Component:	IP Log Tool	Assignee:	Wayne Beaton <wayne.beaton>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	roger
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Wayne Beaton

2016-05-24 11:29:06 EDT

From CQ 11361:

--
I've got these contributions that aren't in the log:

* changyuheng committed on 18 Apr "Make sure loop_stop() would not be stuck"
* changyuheng committed on 18 Apr "Fix loop_start() raising exception when no
internet"
* swails committed with ralight on 12 Apr ""Clean up stray exceptions following
broker disconnect with TLS (#51)"
* changyuheng committed on 8 Apr "Support to limit the number of pending
outgoing messages"

These are from the "fixes" and "develop" branch.
--

Roger, can you tell me the repository and ref for these commits?

Comment 1 Roger Light

2016-05-24 11:47:37 EDT

Repository is https://github.com/eclipse/paho.mqtt.python

And some of the "git log --pretty=fuller" output is below.

I've got to be honest I'm now wondering if the most likely explanation is that I hadn't pushed these changes until after the IP log was submitted.

-----------------------------------------
commit b34f3cb51fcdc93b2cd8798a452a45400c2e37dd
Author:     Chang Yu-heng <mr.changyuheng...>
AuthorDate: Thu Apr 7 16:44:26 2016 -0700
Commit:     Chang Yu-heng <mr.changyuheng...>
CommitDate: Thu Apr 7 16:51:45 2016 -0700

    Support to limit the number of pending outgoing messages
-----------------------------------------
commit b0f38cb44202a511c0a7ea8e2516863a1138c8d1
Author:     Chang Yu-heng <mr.changyuheng...>
AuthorDate: Sun Apr 17 20:40:56 2016 -0700
Commit:     Chang Yu-heng <mr.changyuheng...>
CommitDate: Sun Apr 17 20:41:20 2016 -0700

    Make sure loop_stop() would not be stuck
-----------------------------------------
commit ed255983b491b65c07bad875e980901942514314
Author:     Chang Yu-heng <mr.changyuheng...>
AuthorDate: Sun Apr 17 19:07:43 2016 -0700
Commit:     Chang Yu-heng <mr.changyuheng...>
CommitDate: Sun Apr 17 19:14:15 2016 -0700

    Fix loop_start() raising exception when no internet
-----------------------------------------
commit 984ae86d0d3c0f6c8b3569f61683c329a1a98e04
Author:     Jason Swails <jason...>
AuthorDate: Tue Apr 12 04:48:12 2016 -0400
Commit:     Roger Light <roger...>
CommitDate: Tue Apr 12 09:48:12 2016 +0100

    Clean up stray exceptions following broker disconnect with TLS (#51)

Comment 2 Wayne Beaton

2016-05-24 12:18:47 EDT

Thanks for the refs.

The tool has an optimization by which it reviews only the most recent activity, based on date, when it runs (scanning 100% of every repository gets pretty expensive). The tool does periodically scan the entire repository to catch things that slip through the cracks.

The definition of 'recent activity' is currently set to mean commits from the last month. 

My guess is that these commits where only pulled recently, but since their dates are more than a month old, then were missed by the scanner.

I've changed the definition of recent activity to include all commits from the past year. This should do a better job of catching this sort of activity.

I am rebuilding the data tables. I'll let you know when we're good-to-go.

Comment 3 Wayne Beaton

2016-05-25 14:26:51 EDT

The previously missing commits now appear in the log.

It looks like the problem has been solved.