Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 494322

Summary:	All interaction policies provided by MVC.FX should extend AbstractFXInteractionPolicy.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 (Neon) RC2
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-05-23 11:09:31 EDT

Currently, FXDeleteSelectedOnTypePolicy, FXPanOnTypePolicy, FXPanOrZoomOnScrollPolicy, and FXRotateSelectedOnTypePolicy extend AbstractInteractionPolicy<Node> rather then AbstractFXInteractionPolicy. We should change this for the sake of consistency, even if the methods introduced by AbstractFXInteractionPolicy are not used there up to now.

Comment 1 Alexander Nyßen

2016-05-23 11:13:59 EDT

I pushed the following changes to origin/master:

- Changed superclass of FXDeleteSelectedOnTypePolicy, FXPanOnTypePolicy, FXPanOrZoomOnScrollPolicy, and FXRotateSelectedOnRotatePolicy from AbstractInteractionPolicy to AbstractFXInteractionPolicy.

Even while this is an API change, its should not have an effect on clients and is thus considered as being safe. Resolving as fixed in 4.0.0 RC2.