Bugzilla – Full Text Bug Listing
| Summary: | Change org.apache.derby to import-package in o.e.test.performance | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Marc-André Laperle <malaperle> |
| Component: | Releng | Assignee: | Marc-André Laperle <malaperle> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P2 | CC: | daniel_megert, david_williams, sravankumarl |
| Version: | 4.6 | ||
| Target Milestone: | 4.6.3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/73332 https://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=35e6d7fba0103b6e1c9ffb6b6bff9a34392f3d3e https://git.eclipse.org/r/89127 https://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=5a4c396a70c5c16c5dd96e3557208fdab395940a |
||
| Whiteboard: | |||
|
Description
Marc-André Laperle
Marc-Andre, I just wanted to say thanks for this contribution. Sorry, we couldn't get it into 4.6 -- primarily just because we're having problems displaying our own performance results, but I'm 95% sure it is not only the right fix, but is exactly what is intended -- require a database, but not be tied down to any specific one. If you don't see this go in by mid-July, don't hesitate to remind me. Thanks again, (In reply to David Williams from comment #1) > If you don't see this go in by mid-July, don't hesitate to remind me. It's mid-July :) Gerrit change https://git.eclipse.org/r/73332 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=35e6d7fba0103b6e1c9ffb6b6bff9a34392f3d3e Thanks for the reminder. Now, to be blunt, I am 95% sure that *our* stuff will still work fine with this change. But in the rare event, there is some reason it doesn't, a) we may have to revert, or b) need your continued help to fix whatever requires the "hard coding". :) Thanks again. Note, for the master branch, I incremented bundle version +100 in the service field. http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=11358b2f1203f825706678e2c38b0ea3edbb3f63 If things seem to go ok, in first few "master" builds, we should backport this to maintenance. The reason is that this bundle is used by a number of our features, such as in "buildtools" that analyze the results. So far, we have always used the same version of buildtools for both master and maintenance, so just as well have this match throughout. Were you able to confirm that it works for the platform "master" builds? I checked the last few integration builds and it seems that the performance test haven't been executed since I20160708-1700. (In reply to Marc-Andre Laperle from comment #6) > Were you able to confirm that it works for the platform "master" builds? I > checked the last few integration builds and it seems that the performance > test haven't been executed since I20160708-1700. We have not been able to confirm. Several things changed at the same time, and so far have not tracked why they are not running. The symptoms, so far, do not seem to indicate issues related to missing packages, or simialar, but I can't say I haven't been tempted to try and revert, "just to see" if it makes a difference. (In reply to David Williams from comment #7) > (In reply to Marc-Andre Laperle from comment #6) > > Were you able to confirm that it works for the platform "master" builds? I > > checked the last few integration builds and it seems that the performance > > test haven't been executed since I20160708-1700. > > We have not been able to confirm. Several things changed at the same time, > and so far have not tracked why they are not running. The symptoms, so far, > do not seem to indicate issues related to missing packages, or simialar, but > I can't say I haven't been tempted to try and revert, "just to see" if it > makes a difference. I should have mentioned, bug 498077 is where I am documenting my investigation and findings on why performance tests are not currently running. I think the performance tests are properly running now. Would it be OK to cherry-pick this for 4.6.x? We still have issues with build.eclipse.org, see https://hudson.eclipse.org/shared/job/tracecompass-windows-nightly/388/console New Gerrit change created: https://git.eclipse.org/r/89127 . Gerrit change https://git.eclipse.org/r/89127 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=5a4c396a70c5c16c5dd96e3557208fdab395940a (In reply to Eclipse Genie from comment #12) > Gerrit change https://git.eclipse.org/r/89127 was merged to > [R4_6_maintenance]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/ > ?id=5a4c396a70c5c16c5dd96e3557208fdab395940a Merged to 4.6 maintenance branch Thanks a lot! |