Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 494116

Summary: Connection clips parts of its visualization.
Product: [Tools] GEF Reporter: Matthias Wienand <matthias.wienand>
Component: GEF FXAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nyssen
Version: 0.2.0   
Target Milestone: 4.0.0 (Neon) RC2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 494193    
Bug Blocks:    
Attachments:
Description Flags
Screenshot of the clipping error. none

Description Matthias Wienand CLA 2016-05-20 04:37:35 EDT
Created attachment 261877 [details]
Screenshot of the clipping error.

In some situations, the Connection clips parts of its visualization. For example, the problem is visible when visualizing the following digraph with the "Dot Graph View" (screenshot is attached):

digraph {
    graph[splines=true]
    1->2
    2->3
    3 ->5
    4->5
    2->4
    2->5 1->5
    5->6
    3->6
    6->7
    3->1
    4->6
    3->7
    2->7
    1->7
}
Comment 1 Alexander Nyßen CLA 2016-05-21 02:15:56 EDT
The clipping problem has been resolved by computing the clip (within AbstractInterpolator) based on the visual bounds of the shapes of the connections's curve GeometryNode. Nevertheless, the layout bounds of the connection's curve GeometryNode are sometimes still too small (why now that does no longer affect the clipping) because of an incorrect bounds computations for BezierCurve (bug #494193).
Comment 2 Alexander Nyßen CLA 2016-05-23 13:15:34 EDT
Resolving this as fixed in RC2, as the clipping problem is fixed and the remaining difference of bounds seems to be because of a different interpretation of bounds within AWT/FX and GEF4 Geometry (see bug #494193).