Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 494063

Summary: Required library is incorrectly tagged as needing the node plugin in commonjs scenario
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 10.0   
Target Milestone: 12.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Michael Rennie CLA 2016-05-19 15:07:54 EDT
Consider the following snippet:

/* eslint-env amd */
define([
], function(require) {
	var mod = require('amd/a');
	
});

'amd/a' gets tagged as needing the node plugin (if you started tern without it), when in reality, it needs the commonjs plugin to work properly.
Comment 1 Michael Rennie CLA 2016-05-20 10:54:45 EDT
Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=8b8d507ce0c282d075aa46ddaad5a4f585a57d3a

I also adding loading of the commonjs plugin to the 'optional' pool.

the commonjs plugin lacks a default resolver impl (as stated in the Tern docs), I will ix that in bug 477377.