Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493975

Summary:	ValidateAction.runNonUIValidation(View) does not dispose the new created shell
Product:	[Modeling] Sirius	Reporter:	Florian Barbin <florian.barbin>
Component:	Diagram	Assignee:	Florian Barbin <florian.barbin>
Status:	CLOSED FIXED	QA Contact:	Maxime Porhel <maxime.porhel>
Severity:	normal
Priority:	P3	CC:	julien.dupont, laurent.redor, maxime.porhel
Version:	3.1.0	Keywords:	triaged
Target Milestone:	4.0.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/73141 https://bugs.eclipse.org/bugs/show_bug.cgi?id=491216 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e9a2afbdc2e379096be447a224543ffa9ee7e7db
Whiteboard:
Bug Depends on:	493918
Bug Blocks:

Description Florian Barbin

2016-05-19 03:45:31 EDT

+++ This bug was initially created as a clone of Bug #493918 +++

Currently, the runNonUiValidation method calls the deprecated org.eclipse.gmf.runtime.diagram.ui.OffscreenEditPartFactory.createDiagramEditPart(Diagram) method which instantiates a new shell without disposing it.
The offscreen diagram editParts are still referenced by this shell even if the Sirius session is closed.

Comment 1 Eclipse Genie

2016-05-19 05:23:08 EDT

New Gerrit change created: https://git.eclipse.org/r/73141

Comment 2 Eclipse Genie

2016-05-23 11:49:11 EDT

Gerrit change https://git.eclipse.org/r/73141 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e9a2afbdc2e379096be447a224543ffa9ee7e7db

Comment 3 Laurent Redor

2016-05-23 11:51:46 EDT

Resolved with above commit in Sirius 4.0.0 RC2

Comment 4 Maxime Porhel

2016-05-24 04:28:09 EDT

Validated on Sirius 4.0.0   (4.0.0-N20160523-120044)

Comment 5 Pierre-Charles David

2016-06-24 08:01:16 EDT

Available in Sirius 4.0.0.