Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493936

Summary:	org.eclipse.jface has icons in package folders
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, psuzzi, tom.schindl
Version:	4.6
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	stalebug

Description Markus Keller

2016-05-18 15:17:34 EDT

org.eclipse.jface has icons in package folders. That's wrong. The icons must be moved into the correct icons/full/... folders and references must be fixed.

Comment 1 Markus Keller

2016-05-18 15:20:32 EDT

Also check that the icons are accessed via ImageDescriptor#createFromURL(URL) and HiDPI variants are used if available (bug 382972).

Comment 2 Lars Vogel

2016-05-18 15:41:31 EDT

(In reply to Markus Keller from comment #0)
> org.eclipse.jface has icons in package folders. That's wrong. The icons must
> be moved into the correct icons/full/... folders and references must be
> fixed.

Great to hear, this annoyed me also in the past.

Comment 3 Thomas Schindl

2016-05-19 04:38:05 EDT

I'm not an expert in plain Java-Apps but if you run outside OSGi (and JFace is implemented this way), would that cause a possible regressions if other libraries also keep there icons in "icons/...." package?

Suppose the following

Today:

mylib.jar
  + icons
    + full
      - help.png

jface.jar
  + org
    + eclipse
      + ....
        + icons
          + full
            - help.png

Proposed change:

mylib.jar
  + icons
    + full
      - help.png
jface.jar
  + icons
    + full
      - help.png

Comment 4 Markus Keller

2016-05-19 11:03:58 EDT

JFace already has an /icons/full/ folder that contains images (even some duplicates), so this would not be something new. Loading the scattered icons directly has also caused translation problems in the past, see e.g. bug 176993.

On a flat classpath, I guess there is a chance for conflicts, but that's IMO acceptable for people who choose to run that way.

We should do the cleanup early in 4.7, so that we have enough time to react if anybody has a real problem with it.

Comment 5 Eclipse Genie

2020-01-07 16:59:35 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.