Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493929

Summary:	org.eclipse.images.renderer should support generating alternate resolution pngs into eclipse-png
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Matthias Becker <ma.becker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, Lars.Vogel, ma.becker, markus.kell.r, peter, tmccrary
Version:	4.6
Target Milestone:	4.7 M2
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/74512 https://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=2420da8b21c97644461e6dac945e3e9f3ee2de76
Whiteboard:

Description Markus Keller

2016-05-18 14:39:32 EDT

org.eclipse.images.renderer generates *.hidpi fragments when run with
-Declipse.svg.scale=2

We should add a mode where it generates the alternate resolution pngs into eclipse-png next to the 100% icons.

Comment 1 Markus Keller

2016-05-26 10:50:42 EDT

Assigning to me so it doesn't get forgotten. Feel free to take the bug if you need it earlier.

Comment 2 Matthias Becker

2016-06-03 07:17:31 EDT

Is this (see my Gerrit Change) what you had in mind?
Should I also render the @2x PNGs in the org.eclipse.images project and add it to this change?

Comment 3 Matthias Becker

2016-08-26 07:46:51 EDT

Dear all,

I provided a fix for the reported issue some month ago. Unfortunately I did not hear ANYTHING from your side. If my solution is not what you had in mind: That's totally ok with me. But just hearing nothing is not very nice.

So what's up here? I know that the time of eclipse committers is limited. But in such a situation of limited time and resources eclipse committer should be more inviting more then ever.

Just my 2 cents.

Regards,
Matthias

Comment 4 Lars Vogel

2016-08-26 07:57:02 EDT

Tony, can you review Matthias contribution?

@Matthias, for all svg contributions it is best to add Tony as reviewer. Markus is typical not very responsive in Gerrit reviews.

Comment 5 Eclipse Genie

2016-08-29 10:49:46 EDT

Gerrit change https://git.eclipse.org/r/74512 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=2420da8b21c97644461e6dac945e3e9f3ee2de76

Comment 6 Lars Vogel

2016-08-29 14:53:13 EDT

Thanks Matthias for the patch and Tony for the review.