Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493918

Summary:	ValidateAction.runNonUIValidation(View) does not dispose the new created shell
Product:	[Modeling] Sirius	Reporter:	Florian Barbin <florian.barbin>
Component:	Diagram	Assignee:	Project Inbox <sirius.diagram-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	julien.dupont
Version:	3.1.0	Keywords:	triaged
Target Milestone:	3.1.6
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/73066 https://bugs.eclipse.org/bugs/show_bug.cgi?id=455244 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=894ff9a8368e5e55bb4e4f3487c5ffcf1d705703
Whiteboard:
Bug Depends on:
Bug Blocks:	493975

Description Florian Barbin

2016-05-18 11:42:20 EDT

Currently, the runNonUiValidation method calls the deprecated org.eclipse.gmf.runtime.diagram.ui.OffscreenEditPartFactory.createDiagramEditPart(Diagram) method which instantiates a new shell without disposing it.
The offscreen diagram editParts are still referenced by this shell even if the Sirius session is closed.

Comment 1 Eclipse Genie

2016-05-18 11:53:15 EDT

New Gerrit change created: https://git.eclipse.org/r/73066

Comment 2 Eclipse Genie

2016-05-26 09:48:35 EDT

Gerrit change https://git.eclipse.org/r/73066 was merged to [v3.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=894ff9a8368e5e55bb4e4f3487c5ffcf1d705703

Comment 3 Florian Barbin

2016-06-10 03:31:17 EDT

Fixed on 3.1.x

Comment 4 Pierre-Charles David

2016-10-11 04:38:59 EDT

Available in Sirius 3.1.6.