Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493856

Summary: Can we move "clickthroughs" to readme file?
Product: [Eclipse Project] Platform Reporter: David Williams <david_williams>
Component: RelengAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: arunkumar.thondapu, daniel_megert, tjwatson
Version: 4.6   
Target Milestone: 4.6 RC3   
Hardware: PC   
OS: Linux   
Whiteboard: routine releng

Description David Williams CLA 2016-05-17 19:45:35 EDT
Or, possibly even 'help', if the information there is "permanent limitations". 

The motivation to removing them is that having to "handle" them complicates our "download" logic considerably. 

I used to think there was some "legal reason" for it, but the few I've read recently seemed more about special "how to" information for those platforms. 

Also, I don't think we use all of the current ones, so I guess they could be removed. Though "new" platforms may need corresponding ones added? 

Plus, I am not sure the current content is accurate. It might be, but should be reviewed. 

Our "clickthroughs" can be found in 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.tychoeclipsebuilder/eclipse/clickThroughs
Comment 1 David Williams CLA 2016-05-17 19:51:09 EDT
Arun, can you review the "clickthrough" documents. Please make sure not only accurate, but be explicit about which can be removed, and if some should be added. 

Arun and Dani, do you think acceptable this information be moved to the README file? Or even "help"? 

I guess it has been this way for a long time, but the "user experience" while downloading one of those "clickthoughs" is a lot different than the others. 

Plus, I doubt if a "command line" method of downloading works, if someone one is expecting to specify "get from system-decided mirror" (but admit I have not tried it -- yet).
Comment 2 David Williams CLA 2016-05-17 19:53:02 EDT
Adding Tom to CC since some involve the launcher (I think, though, might be "pure swt").
Comment 3 Dani Megert CLA 2016-05-18 05:55:26 EDT
They were added because we got many duplicate bug reports. Obviously when new people just want to try something out, they won't read the readme. I can't remember when I did this the last time ;-).
Comment 4 Dani Megert CLA 2016-05-18 05:56:39 EDT
(In reply to Dani Megert from comment #3)
> They were added because we got many duplicate bug reports. Obviously when
> new people just want to try something out, they won't read the readme. I
> can't remember when I did this the last time ;-).

So, long story short: I'm fine to clean this up and only keep those where we see the possibility that users fall into a real trap.
Comment 5 David Williams CLA 2016-05-18 08:39:09 EDT
(In reply to David Williams from comment #1)

> Plus, I doubt if a "command line" method of downloading works, if someone
> one is expecting to specify "get from system-decided mirror" (but admit I
> have not tried it -- yet).

So to be honest, the clickthroughs don't effect the "automatically select a mirror" command -- because I had forgotten, it does not go through our custom "download.php" file at all, but the one on "www.eclipse.org". Such as 

$ wget -O eclipse-SDK-I20160517-2000-hpux-gtk-ia64.zip "http://www.eclipse.org/downloads/download.php?file=/eclipse/downloads/drops4/S-4.6RC1-201605121000/eclipse-SDK-4.6RC1-hpux-gtk-ia64.zip&r=1"

But, I still would like to get rid of them. Or, especially, the "flow". 

If it was felt important to "leave on download page", I could eventually just make a new "icon" and "link" to them, which would probably give people a better experience, since they could then more easily download the "instructions" instead of getting a "pop-up" like window. 

IMHO, though, the README would be adequate. 

= = = = = = =

I should point out, the "clickthroughs" do not even work on "released" builds. See bug 399766. So, in all that time we apparently have not gotten many bugs opened.
Comment 6 David Williams CLA 2016-05-22 12:50:39 EDT
I have done the initial move of the clickthrough information to the readme file. 

I just did a "verbatim" copy of the content, I have not checked if still accurate, which needs to be done be SWT team. 

See the readme bug 493368 comment 9. 

I've deleted the files (and directory) from where they were in 
eclipse.platform.releng.tychoeclipsebuilder

Before closing, I'll take a quick look at cleaning up our "index page logic" 
but suspect that is convoluted enough to wait until next release.
Comment 7 David Williams CLA 2016-05-22 13:40:13 EDT
I decided to not even look to fixing the template files at this point in dev cycle. More important work to do. 

Instead, opened an enhancement for next release: bug 494250.
Comment 8 David Williams CLA 2016-05-22 13:49:20 EDT
Just noticed I had forgotten to commit the actual deletion of the clickthrough files: 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=8cac5420b62985ff401e49ce05acc3dbf47795bc