| Summary: | [es6] Import / Export crossfile support has stopped working | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Michael Rennie <Michael_Rennie> |
| Component: | JS Tools | Assignee: | Curtis Windatt <curtis.windatt.public> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | curtis.windatt.public |
| Version: | 12.0 | ||
| Target Milestone: | 12.0 | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ed50898f7164dcbf26f60c295d4bc350c3e44108 Fix The file with the import was behaving as expected. However when resolving the file containing the export statements, the isUsingModules check fails and the exports are added to the global scope. The fix is to mark the es_modules environment as being used whenever we encounter a export declaration (named/default/all). http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f62a34c2ef1a8ad8ce89c310cd083955ac557a51 Enabled the es6 cross file tests. Added new ones for the default export. |
This morning I was playing with some import statement stuff and noticed that crossfile support for imported stuff was not working. The project has the following .tern-project file: { "plugins": { "es_modules": {} }, "libs": [ "ecma5", "ecma6" ], "ecmaVersion": 6, "loadEagerly": [], "sourceType": "module" } I did not matter what I changed in there, the support no longer works. I also tried reverting the escope commit (it was completely unrelated to this, but figured I would rule it out) - with no effect.