Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493724

Summary: Text styling problem in forms
Product: [Eclipse Project] Platform Reporter: Peter Severin <peter>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED DUPLICATE QA Contact:
Severity: major    
Priority: P3 CC: arunkumar.thondapu, ericwill, loskutov, platform-swt-inbox, psuzzi
Version: 4.6   
Target Milestone: 4.6 RC2   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499652
Whiteboard:
Attachments:
Description Flags
Form text styling on Ubuntu 14.04
none
Form text styling on Ubuntu 16.04 none

Description Peter Severin CLA 2016-05-16 03:42:51 EDT
Created attachment 261752 [details]
Form text styling on Ubuntu 14.04

I am testing with Eclipse 4.6 RC1 and there are some styling problems of Text in forms on both Ubuntu 14.04 and Ubuntu 16.04.

On Ubuntu 14.04, selected text is not visible. The field looks empty when text is selected

On Ubuntu 16.04, Text widget has some extra border, and selection is not visible instead, so that selected and unselected text looks exactly the same.
Comment 1 Peter Severin CLA 2016-05-16 03:43:11 EDT
Created attachment 261753 [details]
Form text styling on Ubuntu 16.04
Comment 2 Patrik Suzzi CLA 2016-05-16 05:27:15 EDT
I can reproduce the bug in Ubuntu 15.10 
with Neon (4.6) RC1 
Build id: I20160512-1000

To reproduce: 
- open Plug-in Manifest editor, like in the image [#1]
- try to select text in one of the styled text fields.

You will see that is impossible to select any text.

This definitely is a Major Issue. 

#1 http://i.imgur.com/jA5FYtP.png
Comment 3 Andrey Loskutov CLA 2016-05-16 05:29:09 EDT
Adding SWT to CC. For me looks like an SWT issue.
Comment 4 Arun Thondapu CLA 2016-05-16 06:28:27 EDT
Looks like a duplicate of bug 493015 (has a patch and is targeted for RC2).
Comment 5 Eric Williams CLA 2016-05-16 08:24:23 EDT
(In reply to Arun Thondapu from comment #4)
> Looks like a duplicate of bug 493015 (has a patch and is targeted for RC2).

Correct, that patch should be in for RC2.

*** This bug has been marked as a duplicate of bug 493015 ***
Comment 6 Peter Severin CLA 2016-05-25 00:45:59 EDT
The selection issue was fixed in RC2, however the extra border in text fields wasn't. See the attached screenshot for Ubuntu 16.04.
Comment 7 Peter Severin CLA 2016-08-15 03:07:30 EDT
I can see that the double-border styling is now shown as part of the "New default styling for form-based user interfaces" section in 4.7M1's New and Noteworthy page:
https://www.eclipse.org/eclipse/news/4.7/M1/

Do I understand it correctly that this double-border styling for text fields is now a feature and not a bug?! Am I the only one who finds it ugly?
Comment 8 Andrey Loskutov CLA 2016-08-15 03:18:25 EDT
(In reply to Peter Severin from comment #7)
> I can see that the double-border styling is now shown as part of the "New
> default styling for form-based user interfaces" section in 4.7M1's New and
> Noteworthy page:
> https://www.eclipse.org/eclipse/news/4.7/M1/
> 
> Do I understand it correctly that this double-border styling for text fields
> is now a feature and not a bug?! Am I the only one who finds it ugly?

Peter, please do not use unrelated bugs to discuss some new issues - please create a dedicated bug for this.

And yes, the double-border styling for text fields looks ugly. If this was introduced in 4.7 M1 then this is a regression in my eyes.
Comment 9 Peter Severin CLA 2016-08-15 03:27:46 EDT
Andrey, this is the bug that I've created initially to report text form styling problems, including the one of extra border. See my initial comment and screenshots. This is not a new issue, and I was just pointing out my surprise in seeing this bug presented in milestone release screenshots.
Comment 10 Andrey Loskutov CLA 2016-08-15 03:32:53 EDT
(In reply to Peter Severin from comment #9)
> Andrey, this is the bug that I've created initially to report text form
> styling problems, including the one of extra border. See my initial comment
> and screenshots. This is not a new issue, and I was just pointing out my
> surprise in seeing this bug presented in milestone release screenshots.

Arrgh, I see that the were two issues: selection not shown and the double border. The double border was mentioned later and right now I can't understand if this is a regression or not, because you said that this is new in 4.7M1?

So can we please keep this bug for selection issue (which seem to be fixed now in 4.7 M1), and create a new one for the double border text issue?
Comment 11 Peter Severin CLA 2016-08-15 03:41:32 EDT
Andrey, I've created Bug 499652. Just to make it clear, this is not a new bug and it's also present in Eclipse 4.6. Ideally, it should be fixed in Eclipse 4.6.1.
Comment 12 Andrey Loskutov CLA 2016-08-15 03:43:48 EDT
(In reply to Peter Severin from comment #11)
> Andrey, I've created Bug 499652. Just to make it clear, this is not a new
> bug and it's also present in Eclipse 4.6. Ideally, it should be fixed in
> Eclipse 4.6.1.

Peter, *this* bug can be closed then?
Comment 13 Peter Severin CLA 2016-08-15 03:45:50 EDT
Andrey, yes, this bug can be closed.
Comment 14 Andrey Loskutov CLA 2016-08-15 03:50:53 EDT

*** This bug has been marked as a duplicate of bug 493015 ***