Bugzilla – Full Text Bug Listing
| Summary: | GC#setLineAttributes does not apply its argument to GC | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Peter Severin <peter> |
| Component: | SWT | Assignee: | Alexander Kurtakov <akurtakov> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | akurtakov, ansgar.radermacher, arunkumar.thondapu, markus.kell.r, niraj.modi |
| Version: | 4.6 | Flags: | niraj.modi:
review+
arunkumar.thondapu: review+ |
| Target Milestone: | 4.6 RC2 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/72800 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fe4f8bb968ea3bc87cd534a5996cb18aa246f3b0 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 479614, 493882 | ||
New Gerrit change created: https://git.eclipse.org/r/72800 Thanks Alex for taking care of this, patch looks good. Gerrit change https://git.eclipse.org/r/72800 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fe4f8bb968ea3bc87cd534a5996cb18aa246f3b0 *** Bug 494321 has been marked as a duplicate of this bug. *** Verified in 4.6.0.I20160529-2000. |
Tested with Eclipse 4.6 RC1. The code in question looks like this: public void setLineAttributes(LineAttributes attributes) { if (handle == 0) SWT.error(SWT.ERROR_GRAPHIC_DISPOSED); if (attributes == null) SWT.error(SWT.ERROR_NULL_ARGUMENT); attributes.width = DPIUtil.autoScaleUp(attributes.width); } This method should be calling as its last op the setLineAttributesInPixels method that was introduced with HiDPI support.