Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493694

Summary:

DOT Graph View does not render embedded dot graphs in native mode.

Product:

[Tools] GEF

Reporter:

Tamas Miklossy <miklossy>

Component:

GEF DOT

Assignee:

Alexander Nyßen <nyssen>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

nyssen

Version:

unspecified

Target Milestone:

4.0.0 (Neon) RC1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Render the embedded dot graphs in native mode	nyssen: iplog+

Description Tamas Miklossy

2016-05-14 05:15:54 EDT

When loading a file with embedded dot content in native mode, the invocation of the dot executable tries to process the original file instead of the extracted one. That's why the dot invocation fails with the following output:

Calling '[C:\Program Files (x86)\Graphviz2.38\bin\dot.exe, -oC:\Users\miklossy\AppData\Local\Temp\tmpResult5678028211705558814.dot, C:\eclipse-commiters-mars\runtime-GEF4\Eclipse_wiki_doc_examples\tree.textile]' resulted in exit status: 1.

Comment 1 Tamas Miklossy

2016-05-14 05:29:06 EDT

Created attachment 261744 [details]
Render the embedded dot graphs in native mode

I uploaded a patch with the following fix:

[493694] Render the embedded dot graphs in native mode

- Extend the DotExtractor class with the getDotTempFile() method to create/return a temporary file containing the extracted dot content.
- Modify the DotGraphView.updateGraph() method to pass that temporary file to the dot executable when rendering the embedded dot graphs in native mode.

Hereby I confirm that my contribution complies with https://www.eclipse.org/legal/CoO.php.

Comment 2 Alexander Nyßen

2016-05-16 10:50:56 EDT

Thanks Tamas. I released your fix to origin/master. Resolving as fixed in 4.0.0 RC1.