Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493630

Summary: Need to create connector between two port of same parent view
Product: [Modeling] Papyrus Reporter: Young-Soo Roh <ysroh>
Component: CoreAssignee: Remi Schnekenburger <rschnekenburger>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: charles, papyrus-bugs, peter.cigehn, rschnekenburger
Version: 2.0.1   
Target Milestone: 3.0.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/86448/
https://git.eclipse.org/r/86448
https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=a4536cfed3f603378208491f3a4f9373fb1aa122
https://git.eclipse.org/r/86471
https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=0d41658fd32d4ef701a59f22c64c60646548291c
Whiteboard:
Bug Depends on:    
Bug Blocks: 502424    

Description Young-Soo Roh CLA 2016-05-13 08:37:58 EDT
In Papyrus-RT connector between two ports that shares same parent view must be enabled as they are used often. Currently it prohibited due to connector adivce in Papyrus. 
In ConnectorEditHelper
			// Cannot connect two Port owned by the same view
			if((sourceView.getElement() instanceof Port) && (targetView.getElement() instanceof Port)) {
				if(ViewUtil.getContainerView(sourceView) == ViewUtil.getContainerView(targetView)) {
					return false;
				}
			}

Papyrus-RT structure editor will not be complete until this restriction is removed. Is it possible to remove this restriction so that sub papyrus projects can handle this case through their edit helper?
Comment 1 Young-Soo Roh CLA 2016-05-13 12:25:28 EDT
Note that we were able to create this type of connection on Mars release.
Comment 2 Eclipse Genie CLA 2016-12-06 08:21:29 EST
New Gerrit change created: https://git.eclipse.org/r/86448
Comment 3 Eclipse Genie CLA 2016-12-06 08:36:24 EST
Gerrit change https://git.eclipse.org/r/86448 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=a4536cfed3f603378208491f3a4f9373fb1aa122
Comment 4 Eclipse Genie CLA 2016-12-06 08:36:35 EST
New Gerrit change created: https://git.eclipse.org/r/86471
Comment 5 Peter Cigehn CLA 2016-12-06 11:06:05 EST
I tested this in the context of Papyrus-RT, and you are now able to create connectors between ports of the same capsule (for the case of relay <-> relay and relay <-> internal behavior). I suggest that we put this one into resolved/verified fixed whenever the cherry picked change for the master branch have been merged.
Comment 7 Remi Schnekenburger CLA 2016-12-06 11:10:36 EST
Cherry pick on master has been merged, closing bug as proposed by Peter in previous comment.
Comment 8 Remi Schnekenburger CLA 2016-12-06 11:11:00 EST
And putting into verified fix.