Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493553

Summary: AbstractDomain should provide means to control which operations/transactions should get the undo context applied.
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.2.0   
Target Milestone: 4.0.0 (Neon) RC1   
Hardware: All   
OS: All   
Whiteboard:

Description Alexander Nyßen CLA 2016-05-12 11:42:07 EDT 

    


    


      



        
          Comment 1
        

        
          Alexander Nyßen CLA

        

        
        

        
          2016-05-12 11:43:10 EDT
        

      






The use case is that clients might only want to have content related operations undoable (or even a specific subset). We need to provide a means so clients can control which operations will get the undo context.

    


    


      



        
          Comment 2
        

        
          Alexander Nyßen CLA

        

        
        

        
          2016-05-12 12:15:13 EDT
        

      






I applied the following changes to origin/master:

- Added an applyUndoContext(ITransactionalOperation) to AbstractDomain, which can be overwritten by clients to filter which operations should be undoable.
- Changed contract of IDomain to only execute ITransactionalOperations rather than IUndoableOperations. This way, we can safely decide whether all passed in operations are content relevant or not.

Resolving as fixed in 4.0.0 RC1.