Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493549

Summary: AbstractCompositeOperation should apply unwrap(boolean) recursively.
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.2.0   
Target Milestone: 4.0.0 (Neon) RC1   
Hardware: All   
OS: All   
Whiteboard:

Description Alexander Nyßen CLA 2016-05-12 11:36:45 EDT
Up to now, only the "first level" of operations are unwrapped when applying the unwrapping. If filtering is only applied to the first level, isContentRelevant() may be true for a composite operation, if a no-op content relevant operation is contained on a "lower level". This is a problem, if a specific AbstractDomain wants to filter operations to have only content relevant ones undoable.
Comment 1 Alexander Nyßen CLA 2016-05-12 12:23:35 EDT
Changed implementation of unwrap to unwrap nested composite operations, applying the no-ops filter if required. Resolving as fixed in 4.0.0 RC1.