Bugzilla – Full Text Bug Listing
| Summary: | Using eslint-enable comments doesn't seem to enable the corresponding rule | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Olivier Thomann <Olivier_Thomann> |
| Component: | JS Tools | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | RESOLVED INVALID | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public, Michael_Rennie |
| Version: | 11.0 | ||
| Target Milestone: | 12.0 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Olivier Thomann
After investigation, it looks like this works as expected. /* eslint-enable ...*/ should be used to enable again a rule that has been disabled using /* eslint-disable....*/.Naively I was expecting that /* eslint-enable ... */ located at the top of the file would enable for following rules. Michael, I think I could get that working, but this is controlled inside eslint code so we would need to merge it every time we move to a new version of eslint. (In reply to Olivier Thomann from comment #1) > After investigation, it looks like this works as expected. /* eslint-enable > ...*/ should be used to enable again a rule that has been disabled using /* > eslint-disable....*/.Naively I was expecting that /* eslint-enable ... */ > located at the top of the file would enable for following rules. > Michael, I think I could get that working, but this is controlled inside > eslint code so we would need to merge it every time we move to a new version > of eslint. We should not change eslint for this - its best if we keep eslint as close to upstream as possible. My vote would be wontfix. Ok, closing as INVALID. |