Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 493180

Summary:	Adjust default color scheme for selection feedback and handles.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	4.0.0 (Neon) RC1
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2016-05-07 04:08:58 EDT

As selection color is currently black (primary) and grey (secondary), it cannot be properly identified in situations where the stroke of selected elements is block (which is most likely the case). Also, the light blue for selection handles and the white color of creation handles (bending) are not well distinguishable. We should change the color scheme to make these better recognizable, e.g. by using green as selection color (in contrast to blue for focus).

Comment 1 Alexander Nyßen

2016-05-07 04:18:16 EDT

If we reserve blue for focus, we should ensure that all selection handles orient themselves at the selection color scheme (e.g. green).

Comment 2 Alexander Nyßen

2016-05-07 05:45:12 EDT

We should also consider to inject the color preferences with named bindings rather than defining constants that cannot be simple changed.

Comment 3 Alexander Nyßen

2016-05-09 09:14:43 EDT

I pushed the following changes to origin/master:

- Changed color schema for selection to be based on indigo colors, as this harmonizes with the simultaneously used focus and hover colors.
- Replaced public color constants within feedback and handle parts with named bindings of colors, so they can be easily exchanged via Guice.
- Removed effect provider option from FXHoverFeedbackPart, as this should rather be done via a specialization.
- Added binding for a focus geometry provider for EdgePart to Zest.FX.

Using green or other colors leads to a bad contrast in combination with the light blue focus color. As colors can now be easily exchanged, users can adopt the color scheme as needed.

Revolving as fixed in 4.0.0 RC1.